Skip to content

Abstract the Stove so it can be subclassed #807

Closed
Lordfirespeed wants to merge 4 commits intovectorwing:1.20from
Lordfirespeed:1.20-abstract-stove
Closed

Abstract the Stove so it can be subclassed #807
Lordfirespeed wants to merge 4 commits intovectorwing:1.20from
Lordfirespeed:1.20-abstract-stove

Conversation

@Lordfirespeed
Copy link
Copy Markdown

@Lordfirespeed Lordfirespeed commented Sep 2, 2023

This allows extension mods e.g. Nether's Delight to register their own stoves without having to copy-paste any implementation!

@Lordfirespeed Lordfirespeed changed the base branch from 1.19 to 1.20 September 2, 2023 23:57
@vectorwing vectorwing added the enhancement New feature or request label Aug 5, 2024
@vectorwing
Copy link
Copy Markdown
Owner

Hello! 👋

I believe we had discussed this PR previously on Discord, so I figured I'd ask here this time: are you still interested in updating this PR for the current version?

Due to the nature of the change, I can only add it in a minor version. 1.3 is mostly finished and being ported/tested to 1.21, so let me know if you'd like to update it before this release, and I can take another look.

@Lordfirespeed
Copy link
Copy Markdown
Author

Hallo! I got started on it but it's not done yet. I ran into a few behaviour questions which slowed me down 😅

E.g. presently when an opaque block is placed on top of a stove which is not lit, items are not ejected. is this intentional?

@vectorwing
Copy link
Copy Markdown
Owner

I don't think it's intentional, or at least I didn't intend for that. Probably some forgotten clause inherited from the Campfire.

Either way, this is something I can fix later down, regardless of the abstraction. 👍

@Lordfirespeed
Copy link
Copy Markdown
Author

Superceded by #1265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants