Conversation
Replace manual Runtime creation with get_runtime from pyo3_async_runtimes to properly integrate with the existing async runtime in Python context. This removes the dependency on tokio::runtime::Runtime and simplifies the async execution setup. BREAKING CHANGE: The engine now relies on the existing Python async runtime instead of creating its own Tokio runtime.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace manual Runtime creation with get_runtime from pyo3_async_runtimes to properly integrate with the existing async runtime in Python context. This removes the dependency on tokio::runtime::Runtime and simplifies the async execution setup.
BREAKING CHANGE: The engine now relies on the existing Python async runtime instead of creating its own Tokio runtime.
Summary
Changes
Checklist
cargo build)cargo test --lib --all-features)cargo clippy --all-features)Notes