Repository navigation
[VFDLIBM] Move maven-gpg-plugin to 3.2.8 - #135
Merged
Merged
Conversation
Generated-by: Claude Code (Opus 5.5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
releaseprofile'smaven-gpg-pluginmoves from 3.2.7 to 3.2.8, the newest release; it is one of the plugins.github/dependabot.ymlleaves out, moved by hand after a release (AGENTS.md, "Releases").3.2.8 moves its Bouncy Castle from 1.78.1 to 1.81 (the signer the dry run uses), fixes an empty classifier passed as an empty string, adds
**/*.sigstore.jsonto the default excludes and dropsplexus-xml.The
signgoal's parameters and defaults are the same in both versions'plugin.xml, and the required Maven (3.6.3) and Java are unchanged.Why are the changes needed?
To keep the signing plugin current, with its newer Bouncy Castle, before the next release rather than during it.
Does this PR introduce any user-facing change?
No. Build only; the jar is unchanged.
How was this patch tested?
The dry run (
release.yml, which runs on a change topom.xml) builds the bundle and signs it under 3.2.8 with the Bouncy Castle signer.The owner's own signing through gpg and its agent is not covered by any run; it is first exercised at the next
deploy, or by a localmvn -B -Prelease verifywith signing before it.A
code-review highfound nothing.Generated-by: Claude Code (Opus 5.5)