Skip to content

[VFDLIBM] Cancel a pull request's superseded CI and dry-run runs - #134

Merged
MaxGekk merged 2 commits into
mainfrom
ci-cancel-superseded
Nov 22, 2026
Merged

MaxGekk merged 2 commits into
mainfrom
ci-cancel-superseded

Conversation

@MaxGekk

@MaxGekk MaxGekk commented Nov 22, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

ci.yml gets a concurrency group keyed on the pull request's ref, with cancel-in-progress true for pull_request events only, so a push to a pull request cancels that pull request's run still going.
Any other run (a push to main, a call from release.yml) is keyed on its run id, a group of its own, so it is never cancelled.
release.yml keeps its group release-${{ github.ref }}; cancel-in-progress becomes true on pull requests only, so a tag's or a dispatch's dry run is never cancelled while it runs.
Comments in both files state the cases, including that a re-run of an older run of a pull request cancels the head's run, so only the newest is re-run.

Why are the changes needed?

A stream that pushes several fix commits to one pull request leaves a CI run going per commit; on #131 two ran at once and the stale one was cancelled by hand. Those runs hold runners the nightly and the benchmark dispatches wait for, and their results say nothing about the head.

Does this PR introduce any user-facing change?

No. CI only.

How was this patch tested?

actionlint on both files (one shellcheck info at ci.yml line 193, which this change does not touch).
This pull request was pushed in two commits; the run of the first is cancelled by the push of the second (checked on this pull request's runs).
A code-review high found three nits, all in the comments, which the second commit fixes.

Generated-by: Claude Code (Opus 5.5)

@MaxGekk
MaxGekk merged commit 26c4064 into main Nov 22, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant