Repository navigation
[VFDLIBM] Cancel a pull request's superseded CI and dry-run runs - #134
Merged
Merged
Conversation
added 2 commits
November 22, 2026 17:47
Generated-by: Claude Code (Opus 5.5)
Generated-by: Claude Code (Opus 5.5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ci.ymlgets aconcurrencygroup keyed on the pull request's ref, withcancel-in-progresstrue forpull_requestevents only, so a push to a pull request cancels that pull request's run still going.Any other run (a push to
main, a call fromrelease.yml) is keyed on its run id, a group of its own, so it is never cancelled.release.ymlkeeps its grouprelease-${{ github.ref }};cancel-in-progressbecomes true on pull requests only, so a tag's or a dispatch's dry run is never cancelled while it runs.Comments in both files state the cases, including that a re-run of an older run of a pull request cancels the head's run, so only the newest is re-run.
Why are the changes needed?
A stream that pushes several fix commits to one pull request leaves a CI run going per commit; on #131 two ran at once and the stale one was cancelled by hand. Those runs hold runners the nightly and the benchmark dispatches wait for, and their results say nothing about the head.
Does this PR introduce any user-facing change?
No. CI only.
How was this patch tested?
actionlinton both files (one shellcheck info atci.ymlline 193, which this change does not touch).This pull request was pushed in two commits; the run of the first is cancelled by the push of the second (checked on this pull request's runs).
A
code-review highfound three nits, all in the comments, which the second commit fixes.Generated-by: Claude Code (Opus 5.5)