Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is localized, aligns with the stated issue/PR description, and removes the specific styling overrides that caused poor dark-theme contrast.
Pull request overview
This PR fixes provider logos becoming illegible in dark themes within the Handoff UI by ensuring image-based provider marks always render on a white backing tile and by removing route-chip styling that previously forced the mark background to transparent.
Changes:
- Updated
ProviderMarkto use a fixedbg-whitebacking tile for<img>-based provider logos. - Updated both source and target route chips to stop overriding the mark background with
bg-transparent, preserving the new backing tile.
File summaries
| File | Description |
|---|---|
| app.tsx | Makes provider logo rendering theme-resilient via a white backing tile and prevents route chips from overriding it. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provider logos such as Pi, Cursor and Claude Code render as black artwork against the Handoff panel's dark background. The shared ProviderMark now gives logo images a white backing tile, and both route chips stop overriding that background with transparency. This keeps the original logo colors and the existing initials fallback, covering both the source/target route and the provider picker.
SVG files loaded through img cannot inherit the surrounding application's currentColor. A backing tile addresses that limitation without adding provider-specific assets or inverting colored logos.
Validation: npm run typecheck; npm test (123 tests passed); bb plugin build .
Fixes #1