Skip to content

fix: keep handoff provider logos visible in dark themes - #2

Open
dillonzq wants to merge 1 commit into
vburojevic:mainfrom
dillonzq:fix/provider-mark-dark-theme
Open

dillonzq wants to merge 1 commit into
vburojevic:mainfrom
dillonzq:fix/provider-mark-dark-theme

Conversation

@dillonzq

@dillonzq dillonzq commented Sep 8, 2026

Copy link
Copy Markdown

Provider logos such as Pi, Cursor and Claude Code render as black artwork against the Handoff panel's dark background. The shared ProviderMark now gives logo images a white backing tile, and both route chips stop overriding that background with transparency. This keeps the original logo colors and the existing initials fallback, covering both the source/target route and the provider picker.

SVG files loaded through img cannot inherit the surrounding application's currentColor. A backing tile addresses that limitation without adding provider-specific assets or inverting colored logos.

Validation: npm run typecheck; npm test (123 tests passed); bb plugin build .

Fixes #1

Copilot AI lite review requested due to automatic review settings September 8, 2026 05:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is localized, aligns with the stated issue/PR description, and removes the specific styling overrides that caused poor dark-theme contrast.

Pull request overview

This PR fixes provider logos becoming illegible in dark themes within the Handoff UI by ensuring image-based provider marks always render on a white backing tile and by removing route-chip styling that previously forced the mark background to transparent.

Changes:

  • Updated ProviderMark to use a fixed bg-white backing tile for <img>-based provider logos.
  • Updated both source and target route chips to stop overriding the mark background with bg-transparent, preserving the new backing tile.
File summaries
File Description
app.tsx Makes provider logo rendering theme-resilient via a white backing tile and prevents route chips from overriding it.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent provider icons are difficult to see in Dark theme

2 participants