Skip to content

Improved client creation for Azure OpenAI (inc Entra )#8

Open
joslat wants to merge 2 commits into
vbandi:mainfrom
joslat:main
Open

Improved client creation for Azure OpenAI (inc Entra )#8
joslat wants to merge 2 commits into
vbandi:mainfrom
joslat:main

Conversation

@joslat
Copy link
Copy Markdown

@joslat joslat commented Nov 11, 2024

Some helpers to manage configuration and improved client creation for Azure, including Entra ID Auth.

Addresses #7
possibly #4 too
:)

@joslat
Copy link
Copy Markdown
Author

joslat commented Nov 12, 2024

TODO:
Refactor the provided class so it enables an overload for the current methods to follow the signatures/current structure. So we can send the deployment and endpoint in the FromOpenAIModel/FromOpenAIClient - FromOpenAIKey is only valid for OpenAI - we need more for Azure OpenAI.

Based on the feedback from @vbandi : "We have a trio of static methods for constructing the object: FromOpenAIKey, FromAzureCredential, FromOpenIAClient. I'd like to stick with this pattern."

@vbandi
Copy link
Copy Markdown
Owner

vbandi commented Nov 12, 2024

Thank you @joslat for documenting our discussion!

@vbandi
Copy link
Copy Markdown
Owner

vbandi commented Nov 24, 2024

@joslat I've merged @WailGree 's Azure solution. Can you please check and see if this covers what you need?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants