Conversation
Owner
vbaderks
commented
May 21, 2026
vbaderks
commented
- Add cspell.json config to spelling inside Visual Studio Code
- Enable Segment Heap
- Remove compatibility Id for Windows 7 (already a long time out of support)
- Move IntelliSense workaround to its own header file
There was a problem hiding this comment.
Pull request overview
This PR updates the project to align with newer MSVC build tools (14.51 / VS 18), adds editor spelling support, enables Segment Heap, drops Windows 7 compatibility metadata, and moves the IntelliSense workaround into a dedicated header.
Changes:
- Bump project metadata for newer Visual Studio/MSBuild tooling and enable Segment Heap via MSBuild props.
- Move the IntelliSense workaround from
Macros.hintoIntelliSense.hand add it to the project. - Add
cspell.jsonand expandspelling.dic; remove Windows 7 compatibility ID; rename the About dialog resource ID.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/WICExplorer.vcxproj.filters | Adds IntelliSense.h to the VS filters so it shows under headers. |
| src/WICExplorer.vcxproj | Updates project version metadata and includes IntelliSense.h in the project. |
| src/WICExplorer.rc | Renames About dialog resource ID to IDD_ABOUT_BOX. |
| src/resource.h | Renames About dialog define to IDD_ABOUT_BOX and normalizes a comment. |
| src/Macros.h | Removes the IntelliSense workaround block from a global macro header. |
| src/IntelliSense.h | Introduces a dedicated IntelliSense workaround header. |
| src/ComSmartPointers.h | Switches Windows/COM dependencies to import <Windows-import.h>; and includes IntelliSense.h. |
| src/BitmapDataObject.cpp | Includes IntelliSense.h in the global module fragment. |
| src/app.manifest | Removes Windows 7 supportedOS compatibility entry. |
| src/AboutDlg.cpp | Updates the dialog ID reference to IDD_ABOUT_BOX. |
| spelling.dic | Expands project dictionary words for spell-check tooling. |
| generate-header-units/Windows-import.h | Adds COM smart pointer headers to the Windows header unit wrapper. |
| Directory.Build.props | Adds _CRT_MEMCPY_S_INLINE=inline and enables Segment Heap in Manifest settings. |
| cspell.json | Adds CSpell configuration pointing at spelling.dic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add cspell.json config to spelling inside Visual Studio Code - Enable Segment Heap - Remove compatibility Id for Windows 7 (already a long time out of support) - Move IntelliSense workaround to its own header file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.