Repository navigation
Pair devices by QR code and keep finding the Mac after address changes - #29
Merged
varyform merged 1 commit intoNov 14, 2026
Merged
Conversation
varyform
marked this pull request as ready for review
November 14, 2026 06:20
varyform
added a commit
that referenced
this pull request
Nov 14, 2026
…s unreleased A Mac with VPNs, bridges and IPv6 lists ten addresses, which pushed the rest of Devices off screen though the QR code carries them anyway; the whole row opens them, as Advanced settings does in a game's settings. PR #29 was branched before 2.0.1, so its changelog entries landed under that released heading: they move to Unreleased, with thanks to its author.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NX Play can find a Mac through Bonjour on the same Wi-Fi, but discovery can disappear after an app update or address change. This adds QR pairing and lets the device reconnect through the addresses the user accepted.
This is the focused pairing/reachability successor invited in #11. Sources, Linux and the control API/CLI/MCP are outside this contribution. MacLink remote builds are unchanged.
/v1/helloagainst the Mac ID in the link before sending the pairing code, then saves the user-confirmed address list. A newly discovered address needs confirmation. Manual entry retains compatibility with older NX Play versions without/v1/hello.Mac Settings → Devices, before/after still-state comparison. These are actual Debug app captures using the built-in screenshot mode with synthetic data; listening/install status is sample data. Each still lasts three seconds. The QR sheet opens/dismisses through accessibility, but its capture protection excludes its pixels, so the QR layout and scanning are not visually verified.
Candidate address list, sample data
Validation:
shellcheck nxplay bin/*passes.Draft pending live verification. No iPhone/iPad/controller, camera-permission flow, pairing over GameSheet, cross-host Bonjour/Tailscale, or real port/pairing persistence run. The Mac UI pass used sample data. The owner offered iPhone/iPad pairing checks before merging; CI ran and failed in the MacLink TLS pairing test:
aCodeForgivesMisreadingsAndPairsOncereturned.unreachable(270 tests, one issue). The unsigned build step was skipped after that failure. This matches the inherited MacLink failure seen in local main controls; its cause is being investigated.Created with Anthropic Claude Opus 5.5 in Claude Code; review repairs by OpenAI GPT-6.1 Sol in Codex, through T3 Code. Fresh full-patch independent review: GPT-6.1 Sol, high reasoning, Codex; no actionable executable-source findings. Source approval is separate from runtime and merge readiness.