Repository navigation
fix: report YouTube bot check separately from sign-in errors - #135
Open
vanloctech wants to merge 2 commits into
Open
vanloctech wants to merge 2 commits into
vanloctech wants to merge 2 commits into
Conversation
yt-dlp's "Sign in to confirm you're not a bot" error was classified as YT_SIGNIN_REQUIRED. Add a dedicated YT_BOT_CHECK code, detected before the generic sign-in check in both Rust and TypeScript, with a localized hint to enable browser cookies or switch network/proxy. Closes #129 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…-bot-check # Conflicts: # CHANGELOG.md # docs/CHANGELOG.vi.md # docs/CHANGELOG.zh-CN.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #129.
When YouTube blocks a request with
Sign in to confirm you're not a bot, the error contains "sign in", so Youwee reported it asYT_SIGNIN_REQUIRED("This video requires sign-in"). The real cause is a network or session block, not a video that needs sign-in, so that message sent users the wrong way.YT_BOT_CHECK(non-retryable). It is detected before the generic sign-in check in all four classifiers:parse_ytdlp_error,build_download_error_message,infer_error_code(Rust), andinferBackendErrorCode(TS).parse_ytdlp_error.This PR only reports the error correctly. It doesn't get around YouTube's bot check.
Test plan
tsc, bun tests andcargo checkpass (pre-commit hook)🤖 Generated with Claude Code