Repository navigation
fix: explain age-verification quality limit for YouTube downloads - #134
Merged
Merged
Conversation
When YouTube requires account age-verification for an age-restricted video, yt-dlp can only fetch low-quality formats (usually 360p). Detect the notice on stdout and stderr in both download paths and log a clear explanation once per download. Closes #128 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #128.
If the account behind the cookies hasn't passed YouTube's age verification, yt-dlp prints
This video is age-restricted and YouTube is requiring account age-verification; some formats may be missingand can only fetch low-quality formats (usually format 18, 360p). Before this change the download finished at 360p with no explanation.is_youtube_age_verification_noticedetects that line.log_youtube_age_verification_noticelogs oneinfoentry per download. The entry explains the 360p limit and tells the user to verify their age on YouTube with the cookie account, then refresh cookies.download_videoandhandle_tokio_download). AnAtomicBoolshared across the stdout and stderr readers keeps it to one log entry per download.This PR does not get higher quality for these videos. That requires the user's account to be age-verified.
Test plan
tsc, bun tests andcargo checkpass (pre-commit hook)detects_youtube_age_verification_notice🤖 Generated with Claude Code