Repository navigation
fix(KEN-2403): guard registered-session wake processes - #3370
Conversation
Address review
Address PR review
Address PR review
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Existing watch lifecycle callers misclassify the new unknown process-query status as an absent watch.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds wake-process guarding to registered overseer and master turn ends.
Changes:
- Detects unarmed repeat, single-pass, and configured master wake processes.
- Preserves unknown process-query results and adds regression coverage.
- Updates operational documentation, changelog, and tracked renders.
| File | Description |
|---|---|
hooks/lane-mail-check.sh |
Implements wake checks and reporting. |
hooks/tests/lane-mail-check-wake.test.sh |
Tests wake-check scenarios and controls. |
hooks/tests/lane-mail-check.test.sh |
Updates existing hook tests. |
hooks/tests/lib/lane-mail-world.sh |
Adds wake-process fixtures. |
hooks/README.md |
Documents wake guarding. |
skills/orch/scripts/lib/watch-pid.sh |
Adds unknown process-query status. |
skills/orch/tests/oversee_watch_lifecycle.sh |
Tests failed process queries. |
skills/orch/references/watch-delivery.md |
Documents repeat-watch enforcement. |
changelog.d/added/registered-session-wake-check.md |
Adds release note. |
.claude/hooks/lane-mail-check.sh |
Updates Claude tracked render. |
.codex/hooks/lane-mail-check.sh |
Updates Codex tracked render. |
.pi/kendex/hooks/lane-mail-check.sh |
Updates Pi tracked render. |
.agents/skills/orch/scripts/lib/watch-pid.sh |
Updates installed library render. |
.agents/skills/orch/references/watch-delivery.md |
Updates installed guide render. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Overseer app approval at 21d2fbe (review-gate platform Use 1, declined-unchanged: owner ruling 1790729975).
Copilot reviewed this final head and returned COMMENTED. Both inline threads are Copilot's, each carries a Step 0 decline that holds at this head, and both are resolved:
skills/orch/scripts/lib/watch-pid.sh:91: the new status 2 (query failed) takes the same false branches inoversee-watch,watch_handoverandwatch_restartthat status 1 took before this change, so no claim write orwatch-absentoutcome changes; the one changed caller, the registered-session wake, distinguishes the two and reports the query failure underwake-record. Hardening the unchanged callers is outside this issue's Done-when.skills/orch/references/watch-delivery.md:11: the guide states the missing-follow refusal and its re-arm, and the fresh-lead-turn rule the changelog names is unchanged by the warning-delivery fix; the stale model-context promise was removed in this head.
0 unresolved threads. Required CI is green on the Linux and Cargo jobs; the macOS skill shards are still running on this head, and the lane arms only through the normal route, so a red required job dismisses nothing it should not. The lane's one authorized final range run is in progress on the same head.


Summary
lane-mail-check: wake=unarmedand the start command.Scope
hooks/README.md..kendex-lock.jsonremains unchanged under D007. The overseer refreshes the base checkout after merge.Completed issue
Closes KEN-2403: lane-mail-check: refuse the turn end of a registered overseer or master whose wake process is not running.
Size
allowance_missing.Validation
fcf22312.f1f33474: 2044 seconds,guard-scans, selectionall.21d2fbe5: 1459 seconds,guard-scans, selectionall.21d2fbe5: 1499 seconds,guard-scans, selectionall.Review decisions
Stop.additionalContext; failed process reads stay unknown; the release note names guarded sessions; the guide's stale model-context sentence is removed.Test plan