Skip to content

fix(KEN-2349): install Copilot overseer context readers - #3369

Merged
vanillagreen-fleet-lanes[bot] merged 2 commits into
mainfrom
ken-2349
Oct 1, 2026
Merged

vanillagreen-fleet-lanes[bot] merged 2 commits into
mainfrom
ken-2349

Conversation

@vanillagreen-fleet-lanes

Copy link
Copy Markdown
Contributor

Summary

  • Share the existing Copilot context-reader installer and hook gate through lib/adapters/copilot.sh.
  • Install the reader before overseer launch and succession. Registration configures the reader for the next session and warns when its harness has no turn-end hook.
  • Report an overseer's missing reader at SessionStart. Preserve the operator's EXTENSIONS=false choice and the existing statusLine fallback.

Cause and evidence

  • The previous code installed the context extension only through open-terminal. Overseer launch, registration and succession did not call that installer.
  • Registration accepted a harness whose checkout had no turn-end hook. The issue identifies the vgs manifest's previous omission of Copilot.
  • Owner-machine evidence is retained in tmp/lane-mail/KEN-2349/to-lane.jsonl, envelope 1790839423-3329330-30825, collected on 2026-10-01 at 07:19:43Z. It records the vgs manifest repair in commit 2b6546859, the installed extension copies and enabled flags in both Copilot homes, and older session compaction-start records.
  • That evidence cannot recover before-repair hook output. The operator's oversee-succeed --check-marks ran from the master pane %89 and returned harness-unnamed. It does not prove vgs succession.
  • The fixture drives the installed extension, real hook and real oversee-succeed --check-marks judgment. It reaches context succession on this fix, but not on archived actual main without the installer. Live vgs succession remains a separate pending proof.

Completed issue

Closes KEN-2349

Acceptance map

  • Shared installer and all launch paths: adapter, open-terminal, overseer launch library and oversee-succeed, with first-turn fixtures and installer-drop controls.
  • Registration checks: oversee register uses the Copilot hook gate or kendex inventory for the other harnesses. Missing hooks warn without rejecting the running session.
  • Missing-reader report: lane-mail-check's SessionStart path, with the no-reader fixture and its must-fail control.
  • Succession verdict: the retained actual-main comparison and mark-judgment controls.

Test plan

  • Scoped orch battery: 479 passing assertions across the affected suites.
  • Actual-main proof: 114 passing assertions.
  • Hook suite after the ordered SessionStart expectation correction: 191 passing assertions.
  • Configured full validation: tools/guard --full, passed through dev-validate-run.
  • Configured range validation: passed through dev-validate-run.
  • Normal commit chain: passed, including the D015 md-refs check with zero violations.
  • Internal architecture, correctness, error handling and test reviews found no blocker. The documentation-only correction passed range validation and the normal commit chain. Its scoped documentation re-review passed.
  • External review produced no artifact because Claude timed out after 1080 seconds. It did not supply a passing verdict.

Size

  • Final branch: 239 added production lines, 268 added test lines, and 266 render-mirror lines.
  • Issue allowance: 40 production lines and 60 test lines. Verdict: over.
  • The architecture review identified no production cut that preserves the added acceptance requirements.

Consumer action and limits

  • vgs must include copilot in its install harness list and apply that manifest in its own checkout. The owner evidence records its manifest repair.
  • A reader installed during registration loads at the next session start.
  • This lane did not refresh or apply project installation state. It did not change .kendex-lock.json.

Copilot AI balanced review requested due to automatic review settings October 1, 2026 12:37
@linear-code

linear-code Bot commented Oct 1, 2026

Copy link
Copy Markdown

KEN-2349

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approved

The identified configuration-side-effect, diagnostic, and coverage findings are non-blocking suggestions.

Review effort: Balanced
Findings: 1 Medium severity · 3 Low severity

Open (4)
What changed in this PR

Centralizes Copilot context-reader installation and applies it across overseer lifecycle paths.

Changes:

  • Shares reader installation and hook validation through the Copilot adapter.
  • Adds registration and SessionStart diagnostics.
  • Expands integration tests, documentation, changelog, and rendered copies.
File Description
skills/​orch/​tests/​oversee_succeed.sh Tests succession reader installation.
skills/​orch/​tests/​oversee_launch.sh Tests launch, registration, and inventory checks.
skills/​orch/​tests/​open-terminal-harness-gate.sh Updates shared-adapter controls.
skills/​orch/​tests/​open-terminal-copilot-context.sh Tests first-turn context flow.
skills/​orch/​tests/​lib/​copilot-context-world.sh Adds shared Copilot context fixture.
skills/​orch/​scripts/​oversee-succeed Updates succession diagnostics.
skills/​orch/​scripts/​oversee Installs readers and checks hook coverage.
skills/​orch/​scripts/​open-terminal Delegates reader and hook gates.
skills/​orch/​scripts/​lib/​overseer-launch.sh Installs readers during launch selection.
skills/​orch/​scripts/​lib/​adapters/​copilot.sh Owns shared installation and validation.
skills/​orch/​references/​copilot-runtime.md Documents the revised lifecycle.
hooks/​tests/​lane-mail-check-copilot.test.sh Updates SessionStart expectations.
hooks/​lane-mail-check.sh Reports missing overseer readers.
changelog.d/​fixed/​copilot-overseer-reader.md Records the user-facing fix.
.pi/​kendex/​hooks/​lane-mail-check.sh Mirrors the hook update for Pi.
.codex/​hooks/​lane-mail-check.sh Mirrors the hook update for Codex.
.claude/​hooks/​lane-mail-check.sh Mirrors the hook update for Claude.
.agents/​skills/​orch/​scripts/​oversee-succeed Mirrors succession changes.
.agents/​skills/​orch/​scripts/​oversee Mirrors registration changes.
.agents/​skills/​orch/​scripts/​open-terminal Mirrors terminal-launch changes.
.agents/​skills/​orch/​scripts/​lib/​overseer-launch.sh Mirrors launch-library changes.
.agents/​skills/​orch/​scripts/​lib/​adapters/​copilot.sh Mirrors adapter changes.
.agents/​skills/​orch/​references/​copilot-runtime.md Mirrors runtime documentation.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread skills/orch/scripts/lib/overseer-launch.sh
Comment thread skills/orch/scripts/oversee
Comment thread skills/orch/scripts/oversee
Comment thread skills/orch/scripts/oversee
@vanillagreen-fleet-lanes
vanillagreen-fleet-lanes Bot added this pull request to the merge queue Oct 1, 2026
Merged via the queue into main with commit b315ac6 Oct 1, 2026
77 checks passed
@vanillagreen-fleet-lanes
vanillagreen-fleet-lanes Bot deleted the ken-2349 branch October 1, 2026 13:55
@vanillagreen-fleet-lanes

Copy link
Copy Markdown
Contributor Author

Completion Summary

KEN-2349 merged in PR #3369 as b315ac6420fb0027e5a6156648e0a2419a245b56 at 2026-10-01T13:55:26Z (6:55 am Pacific).

Acceptance

  • The diagnosis names the missing shared reader installer and missing Copilot hook coverage, with source and owner-machine evidence in the PR body.
  • The adapter owns the existing installer and hook gate. All required entry paths call it.
  • First-turn fixtures cover open-terminal, launch, succession and registration after its next start. The actual-main control reaches the real check-marks judgment on the fix, but not archived main without installation.
  • SessionStart reports a fleet-recorded Copilot overseer with no reader.
  • Registration warns about missing hook coverage and still records the running session.
  • Live vgs succession is not claimed. The operator's master check-marks output is not that proof.

Validation and review

  • Hook suite: 191 passing assertions. Scoped orch: 479 passing assertions. Actual-main proof: 114 passing assertions.
  • Configured full and range validation and normal commit chains passed. D015 md-refs passed with zero violations.
  • The doc-only follow-up passed range validation and scoped doc re-review. Copilot approved the exact final head. All review threads are resolved, including the post-merge read.
  • The non-blocking failed-install registration coverage gap has Proposal comment 49cfda92-e812-4eb2-be91-e21f1ba72ee5 on KEN-2349. The overseer bound it for the proposal sweep after merge. No runtime defect is claimed from the absent test row.
  • External review timed out and supplied no passing verdict.

Post-merge state

  • The merge is on origin/main. The changed production and fixture paths match the approved head.
  • A live Linear read already reported Done. The completed acceptance boxes are now checked. No duplicate Done transition was needed.
  • Base sync refused because the base checkout has a modified .kendex-lock.json. The lane preserved that file. Local main remains 53098d7b557c521ceaa9af1d65a2db43523c2620; origin/main is b315ac6420fb0027e5a6156648e0a2419a245b56.
  • The overseer owns the base refresh and hosted lane disposal. The worktree remains clean for that close-out.
  • No sync --reconcile, kendex refresh or kendex apply ran. The branch did not change .kendex-lock.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant