fix(KEN-2349): install Copilot overseer context readers - #3369
Merged
Merged
Conversation
Address review
Copilot started reviewing on behalf of
vanillagreen (vanillagreencom)
October 1, 2026 12:38
View session
There was a problem hiding this comment.
Copilot review overview
🟢 Approved
The identified configuration-side-effect, diagnostic, and coverage findings are non-blocking suggestions.
Review effort: Balanced
Findings: 1
Open (4)
What changed in this PR
Centralizes Copilot context-reader installation and applies it across overseer lifecycle paths.
Changes:
- Shares reader installation and hook validation through the Copilot adapter.
- Adds registration and SessionStart diagnostics.
- Expands integration tests, documentation, changelog, and rendered copies.
| File | Description |
|---|---|
skills/orch/tests/oversee_succeed.sh |
Tests succession reader installation. |
skills/orch/tests/oversee_launch.sh |
Tests launch, registration, and inventory checks. |
skills/orch/tests/open-terminal-harness-gate.sh |
Updates shared-adapter controls. |
skills/orch/tests/open-terminal-copilot-context.sh |
Tests first-turn context flow. |
skills/orch/tests/lib/copilot-context-world.sh |
Adds shared Copilot context fixture. |
skills/orch/scripts/oversee-succeed |
Updates succession diagnostics. |
skills/orch/scripts/oversee |
Installs readers and checks hook coverage. |
skills/orch/scripts/open-terminal |
Delegates reader and hook gates. |
skills/orch/scripts/lib/overseer-launch.sh |
Installs readers during launch selection. |
skills/orch/scripts/lib/adapters/copilot.sh |
Owns shared installation and validation. |
skills/orch/references/copilot-runtime.md |
Documents the revised lifecycle. |
hooks/tests/lane-mail-check-copilot.test.sh |
Updates SessionStart expectations. |
hooks/lane-mail-check.sh |
Reports missing overseer readers. |
changelog.d/fixed/copilot-overseer-reader.md |
Records the user-facing fix. |
.pi/kendex/hooks/lane-mail-check.sh |
Mirrors the hook update for Pi. |
.codex/hooks/lane-mail-check.sh |
Mirrors the hook update for Codex. |
.claude/hooks/lane-mail-check.sh |
Mirrors the hook update for Claude. |
.agents/skills/orch/scripts/oversee-succeed |
Mirrors succession changes. |
.agents/skills/orch/scripts/oversee |
Mirrors registration changes. |
.agents/skills/orch/scripts/open-terminal |
Mirrors terminal-launch changes. |
.agents/skills/orch/scripts/lib/overseer-launch.sh |
Mirrors launch-library changes. |
.agents/skills/orch/scripts/lib/adapters/copilot.sh |
Mirrors adapter changes. |
.agents/skills/orch/references/copilot-runtime.md |
Mirrors runtime documentation. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
Completion SummaryKEN-2349 merged in PR #3369 as Acceptance
Validation and review
Post-merge state
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
lib/adapters/copilot.sh.EXTENSIONS=falsechoice and the existing statusLine fallback.Cause and evidence
open-terminal. Overseer launch, registration and succession did not call that installer.tmp/lane-mail/KEN-2349/to-lane.jsonl, envelope1790839423-3329330-30825, collected on 2026-10-01 at 07:19:43Z. It records the vgs manifest repair in commit2b6546859, the installed extension copies and enabled flags in both Copilot homes, and older session compaction-start records.oversee-succeed --check-marksran from the master pane%89and returnedharness-unnamed. It does not prove vgs succession.oversee-succeed --check-marksjudgment. It reaches context succession on this fix, but not on archived actual main without the installer. Live vgs succession remains a separate pending proof.Completed issue
Closes KEN-2349
Acceptance map
Test plan
tools/guard --full, passed throughdev-validate-run.dev-validate-run.Size
Consumer action and limits
copilotin its install harness list and apply that manifest in its own checkout. The owner evidence records its manifest repair..kendex-lock.json.