fix(KEN-2266): preserve proven overseer registration fields - #3300
Merged
Merged
Conversation
Copilot started reviewing on behalf of
vanillagreen (vanillagreencom)
September 30, 2026 18:59
View session
Contributor
Author
Completed issues
Recommendations processedFixed in PR
Dropped
Review and validation
Fix rounds: 1. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approved
The implementation and regression coverage are sound; only non-blocking field-report terminology needs clarification.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Preserves overseer registration data only when the existing record proves the same tmux pane.
Changes:
- Retains unread identity and launch fields for the same pane.
- Reports retained versus newly written fields.
- Adds regression controls, schema documentation, renders, and changelog coverage.
| File | Description |
|---|---|
skills/orch/tests/oversee_launch.sh |
Tests preservation and pane isolation. |
skills/orch/scripts/oversee |
Reports retained and fresh fields. |
skills/orch/scripts/lib/overseer-launch.sh |
Implements conditional record merging. |
skills/orch/schemas/workflow-state.md |
Documents registration semantics. |
changelog.d/fixed/KEN-2266-overseer-register.md |
Records the consumer-facing fix. |
.agents/skills/orch/scripts/oversee |
Updates the committed render. |
.agents/skills/orch/scripts/lib/overseer-launch.sh |
Updates the committed render. |
.agents/skills/orch/schemas/workflow-state.md |
Updates the committed schema render. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
Orchestration stopped
|
Contributor
Author
|
KEN-2266 is merged and Done.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Completed issues
Requirements and files
skills/orch/scripts/lib/overseer-launch.shand its.agentsrender.skills/orch/scripts/overseeand its.agentsrender.skills/orch/tests/oversee_launch.sh.skills/orch/schemas/workflow-state.mdand its.agentsrender.changelog.d/fixed/KEN-2266-overseer-register.md.Size
allowance_missing.standardbecause the required changelog joined the skill subsystem. The lane continued under the standard workflow.Test plan
ce2fcbcd3b880279b38c7622c99e21cdf5d76397:tools/guard --full, exit 0.oversee_launchsuite passed 140 assertions.