Skip to content

fix(KEN-2266): preserve proven overseer registration fields - #3300

Merged
vanillagreen-fleet-lanes[bot] merged 2 commits into
mainfrom
ken-2266
Sep 30, 2026
Merged

vanillagreen-fleet-lanes[bot] merged 2 commits into
mainfrom
ken-2266

Conversation

@vanillagreen-fleet-lanes

Copy link
Copy Markdown
Contributor

Summary

  • Preserve unread overseer-record fields when server, server start and pane identify the same session.
  • Merge only non-empty identity values. Keep an existing launch line when no new line is passed. Do not inherit another pane's identity.
  • Report retained and freshly read fields in the registration output. Update the schema and committed renders.

Completed issues

  • Closes KEN-2266: oversee register keeps every overseer-record field it cannot read afresh.

Requirements and files

  • Same-pane preservation and different-pane isolation: skills/orch/scripts/lib/overseer-launch.sh and its .agents render.
  • Registration field report: skills/orch/scripts/oversee and its .agents render.
  • Regression cases and must-fail controls: skills/orch/tests/oversee_launch.sh.
  • Record semantics: skills/orch/schemas/workflow-state.md and its .agents render.
  • Consumer change: changelog.d/fixed/KEN-2266-overseer-register.md.

Size

  • 43 production, 63 test and 42 render-mirror lines added.
  • No Expected delta allowance. Verdict: allowance_missing.
  • Started at small tier. The classifier measured standard because the required changelog joined the skill subsystem. The lane continued under the standard workflow.

Test plan

  • Full configured validation passed at final head ce2fcbcd3b880279b38c7622c99e21cdf5d76397: tools/guard --full, exit 0.
  • The implementation full run passed all 148 orch suites and 8742 assertions. The oversee_launch suite passed 140 assertions.
  • Same-pane registration without a SessionStart row keeps harness, model, effort and launch_line. Fresh values replace old values. A different pane does not inherit the old harness.
  • Must-fail controls detect the original blanking write and an unbound prior-record merge.
  • Removed the unconditional launch-line deletion control because its premise no longer holds for the same proven pane. The blanking and different-pane inheritance controls cover the replacement contract.
  • Correctness, error handling and test reviewers passed. Test mutation: killed 1/1. Stability: 10/10 at 4 threads.
  • Fixed the documentation review's stale model-and-effort claim. Focused re-review passed.
  • Tests used fixture fleet state and a private tmux server. No live control-fleet registration or launch ran.

Copilot AI balanced review requested due to automatic review settings September 30, 2026 18:58
@linear-code

linear-code Bot commented Sep 30, 2026

Copy link
Copy Markdown

KEN-2266

@vanillagreen-fleet-lanes

Copy link
Copy Markdown
Contributor Author

Completed issues

Recommendations processed

Fixed in PR

  • reviewer-doc: corrected the stale model-and-effort schema claim in ce2fcbc. Focused re-review passed.

Dropped

  • Schema-render validation selects all orch suites when it has no narrower mapping. This is a deliberate fail-closed fallback, not a correctness defect. No issue filed.

Review and validation

  • Correctness, error handling and test review passed.
  • Final-head full validation passed at ce2fcbc.
  • Test mutation: killed 1/1. Stability: 10/10 at 4 threads.
  • No open local finding remains.

Fix rounds: 1.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approved

The implementation and regression coverage are sound; only non-blocking field-report terminology needs clarification.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Preserves overseer registration data only when the existing record proves the same tmux pane.

Changes:

  • Retains unread identity and launch fields for the same pane.
  • Reports retained versus newly written fields.
  • Adds regression controls, schema documentation, renders, and changelog coverage.
File Description
skills/​orch/​tests/​oversee_launch.sh Tests preservation and pane isolation.
skills/​orch/​scripts/​oversee Reports retained and fresh fields.
skills/​orch/​scripts/​lib/​overseer-launch.sh Implements conditional record merging.
skills/​orch/​schemas/​workflow-state.md Documents registration semantics.
changelog.d/​fixed/​KEN-2266-overseer-register.md Records the consumer-facing fix.
.agents/​skills/​orch/​scripts/​oversee Updates the committed render.
.agents/​skills/​orch/​scripts/​lib/​overseer-launch.sh Updates the committed render.
.agents/​skills/​orch/​schemas/​workflow-state.md Updates the committed schema render.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread skills/orch/scripts/lib/overseer-launch.sh
@vanillagreen-fleet-lanes

Copy link
Copy Markdown
Contributor Author

Orchestration stopped

  • Stop: ci-status-unconfirmed
  • Gate: ci
  • Remaining: Both bounded CI waits timed out with macOS jobs QUEUED and no failed checks. PR is unarmed; final-head approval and Review gate are green.

@vanillagreen-fleet-lanes
vanillagreen-fleet-lanes Bot added this pull request to the merge queue Sep 30, 2026
Merged via the queue into main with commit b82e359 Sep 30, 2026
68 checks passed
@vanillagreen-fleet-lanes
vanillagreen-fleet-lanes Bot deleted the ken-2266 branch September 30, 2026 20:55
@vanillagreen-fleet-lanes

Copy link
Copy Markdown
Contributor Author

KEN-2266 is merged and Done.

  • PR: fix(KEN-2266): preserve proven overseer registration fields #3300.
  • Merge: b82e359.
  • Time: September 30, 2026 at 1:55 pm Pacific (2026-09-30T20:55:38Z).
  • The merged commit is on main. The runtime, regression tests, changelog and renders match the reviewed head. The merged schema keeps the corrected overseer contract; its other changes came from concurrent main work.
  • Linear live read confirms KEN-2266 is Done. It has no parent or unfinished child. The merge integration completed it, so no duplicate complete write is needed.
  • Local full validation passed. Correctness, error, tests and focused schema re-review passed. The final head received Copilot approval. The terminology suggestion was declined with a passing-state reason and resolved. No finding remains undecided.
  • Queue-wait returned merged. The post-merge thread read found no unresolved thread.
  • Warning: the lane-end sync --reconcile call timed out. No sync process remains. The subsequent live Linear read confirms Done; full-cache reconciliation is not claimed.
  • The hosted worktree is clean and remains in place. The sandbox base checkout, install record and live control-fleet state remain untouched by cleanup. The overseer owns base sync, refresh and lane-close.
  • Workflow state and lane evidence are archived at /home/dev/.fleet/archive/kendex/oversee/close-KEN-2266-1790802264-UeOFX0.tgz.
  • Mailbox monitoring ends with this completed lane. The overseer can run lane-close for sandbox disposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant