Open
Conversation
Signed-off-by: Abhishek Paul <paul.apaul.abhishek.ap@gmail.com>
Author
|
@hamchapman please look into this PR, to unblock crashes in ios apps consuming this library. |
Author
|
@hamchapman, @valpackett Any update on this? Would be really helpful if any one of you can look into this.Thanks |
Owner
It's not "defaulting", currently it's just entirely hardcoded, which I'm rather iffy about. What if I do want to handle 10 million entries? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR prevents potential crashes and unsafe decoding results when encountering invalid or malicious CBOR inputs. Specifically:
nilsilently, instead of throwing a meaningful error.These issues can lead to application crashes or unexpected behavior in production.
Changes
readLength(), defaulting to 200,000 elements.CBORError.tooLongSequenceif the declared array or map length exceeds this limit.defaultcase indecodeItem()to always throwCBORError.unfinishedSequencefor unknown or malformed input.nilreturn from decoding, ensuring consistent error behavior on corrupt data.Rationale
Testing
CBORError.tooLongSequencewhen encountering absurd array or map sizes.CBORError.unfinishedSequence.Notes
Linked Issues