Open
Conversation
- Updated `rebar.config` to format dependencies for better readability. - Enhanced `ensure_otel_log_handler` function in `hellgate.erl` to allow dynamic log level configuration. - Simplified log report formatting in `hg_otel_log_filter.erl`. - Streamlined test suite in `hg_log_delivery_tests_SUITE.erl` to focus on OTel log delivery. - Added `otel_log_level` configuration in `sys.config` for improved log level management.
nanodirijabl
approved these changes
Feb 20, 2026
nanodirijabl
approved these changes
Feb 24, 2026
Comment on lines
+143
to
+146
| case SpanCtx of | ||
| undefined -> ok; | ||
| _ -> _ = otel_span:end_span(SpanCtx, undefined) | ||
| end, |
Contributor
There was a problem hiding this comment.
Кажется что можно без кейса. end_span/2 вроде принимает произвольный терм и сам сопоставляет с ожидаемым рекордом если спан-контекст передан аргументом.
Comment on lines
+150
to
+157
| mk_span_name('ProcessSignal', NS) -> | ||
| iolist_to_binary(["hellgate signal ", ns_to_binary(NS)]); | ||
| mk_span_name('ProcessCall', NS) -> | ||
| iolist_to_binary(["hellgate call ", ns_to_binary(NS)]); | ||
| mk_span_name('ProcessRepair', NS) -> | ||
| iolist_to_binary(["hellgate repair ", ns_to_binary(NS)]); | ||
| mk_span_name(Func, NS) -> | ||
| iolist_to_binary(["hellgate ", atom_to_binary(Func), " ", ns_to_binary(NS)]). |
Contributor
There was a problem hiding this comment.
Префикс "hellgate " для имён спанов кажется лишним, ведь экспортироваться он будет уже от имени соответствующего сервиса.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.