fix(isHSL): allow optional whitespace after alpha separator - #2887
Open
Shuran-z wants to merge 1 commit into
Open
fix(isHSL): allow optional whitespace after alpha separator#2887Shuran-z wants to merge 1 commit into
Shuran-z wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2887 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2599 2599
Branches 658 658
=========================================
Hits 2599 2599 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isHSL('hsl(120 100% 50%/0.5)')returnsfalse, while the equivalent value with spaces around/returnstrue. The modern HSL expression requires a whitespace character after the alpha separator even though the separator already delimits the alpha token.Make that whitespace optional. The existing whitespace normalization remains unchanged. Regression cases cover all four spacing combinations for
hsl()andhsla(), numeric and percentage alpha values, and rejection of missing alpha values, duplicate separators, and whitespace inside numeric tokens.Reference: CSS Color 4: HSL colors.
Validation on Windows with Node.js 24.19.0:
hsl(120 100% 50%/0.5)and passes after the fix.npm test: builds Node, ES module, and browser distributions, passes ESLint, and reports 324 passing tests.git diff --checkpasses.Checklist