fix(isRgbColor): keep numeric values contiguous when allowing spaces - #2886
Open
emme1t wants to merge 1 commit into
Open
fix(isRgbColor): keep numeric values contiguous when allowing spaces#2886emme1t wants to merge 1 commit into
emme1t wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2886 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2599 2600 +1
Branches 658 658
=========================================
+ Hits 2599 2600 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2885.
With
allowSpaces: true, values such asrgb(2 55,0,0)andrgba(0,0,0,0. 5)currently pass because whitespace removal joins separate parts of a number. Check for whitespace inside numeric and percentage tokens before the existing normalization step.Regression coverage includes integer channels, percentage channels, decimal alpha values, spaces, tabs, and newlines. Whitespace around complete values remains accepted, and both
includePercentValuessettings are covered.Validation on Windows with Node.js 24.16.0:
rgb(2 55,0,0).npm test: builds and ESLint passed; 324 tests passed.CSS.supports('color', value); all results match the regression expectations.git diff --check: passed.Checklist
AI assistance: OpenAI Codex prepared the change, ran the local checks, and performed a separate review of the patch.