feat(add-project): native folder picker (Finder) in the desktop app - #261
Merged
Conversation
The "Add project → Local path" field only had a text input + a datalist of known folders; the native datalist popup overflows and can't be scrolled/ styled, and there was no way to browse for a folder. - Desktop: add a preload bridge (window.codbashDesktop.pickFolder) + an ipcMain 'codbash:pick-folder' handler that opens the native openDirectory dialog and returns the chosen absolute path. Wire preload into the BrowserWindow (contextIsolation stays on, nodeIntegration off). - Frontend: a "Browse…" button next to the path input, shown only when the desktop bridge is present (hidden in the plain browser, which keeps the datalist). Picking a folder fills the input with its absolute path. Browser keeps the datalist autocomplete unchanged (verified: button hidden, 78 suggestions, no bridge, 0 console errors). Takes effect in the installed app after a desktop rebuild. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Add project → Local path" field only had a text input + a
<datalist>of known folders. The native datalist popup overflows the modal and can't be scrolled/styled, and there was no way to browse for a folder. Reported: "выбор проекта не скроллится, я бы Finder открывал".window.codbashDesktop.pickFolder) + anipcMaincodbash:pick-folderhandler that opens the nativeopenDirectorydialog and returns the chosen absolute path. Preload wired into theBrowserWindow(contextIsolation stays on, nodeIntegration off) — the renderer only sees that one method.Browser verified: button hidden, 78 datalist suggestions still populate, no bridge, 0 console errors. Takes effect in the installed app after a desktop rebuild.
🤖 Generated with Claude Code