Conversation
Adds a `wake-lock` module mirroring the `page-visibility` and `geolocation` modules, with four use cases exercising the new `Page#getWakeLock()` facade from vaadin/flow#23619: - UC1 Manual toggle — minimal API exercise, button + status badge bound to `wakeLock.activeSignal()`. - UC2 Recipe — lifetime-of-view pattern; `request()` on attach and `release()` on detach. - UC3 Slideshow — `Signal.effect` couples the lock to a `presenting` signal, so reaching the last slide also releases the lock. - UC4 Workout timer — HIIT timer coupling the lock to a `running` signal; uses `TaskScheduler` + `ui.accessLater` for ticks. Each view has a browserless test; tests reach into the package-private `WakeLock#setActive` via a reflective `WakeLockTestSupport` helper, mirroring `PageVisibilityTestSupport`. `wake-lock/API-GAPS.md` records six friction points observed while building the views (notably the missing test simulator and missing server-side feature detection). Pins `flow.version` to `25.2.wake-lock-SNAPSHOT`; revert to a mainline snapshot once the PR is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
wake-lockmodule mirroring thepage-visibilityandgeolocationmodules, with four use cases exercising the newPage#getWakeLock()facade from vaadin/flow#23619:wakeLock.activeSignal().request()on attach andrelease()on detach.Signal.effectcouples the lock to apresentingsignal, so reaching the last slide also releases the lock.runningsignal; usesTaskScheduler+ui.accessLaterfor ticks.Each view has a browserless test; tests reach into the package-private
WakeLock#setActivevia a reflectiveWakeLockTestSupporthelper, mirroringPageVisibilityTestSupport.wake-lock/API-GAPS.mdrecords six friction points observed while building the views (notably the missing test simulator and missing server-side feature detection).Pins
flow.versionto25.2.wake-lock-SNAPSHOT; revert to a mainline snapshot once the PR is merged.