feat: SignalInput — read a server-side Signal at trigger fire time#24428
Open
Artur- wants to merge 1 commit into
Open
feat: SignalInput — read a server-side Signal at trigger fire time#24428Artur- wants to merge 1 commit into
Artur- wants to merge 1 commit into
Conversation
Adds SignalInput<T>(Component owner, Signal<T> signal) under com.vaadin.flow.component.trigger.internal. A component-scoped Signal.effect mirrors the signal value to a uniquely-named JS property on the owner element via executeJs; the input's rendered expression reads that property at fire time, so actions such as CopyTextToClipboardAction can use a server-side signal as their value source without first projecting it onto a DOM property. Includes unit tests covering the rendered expression, push-on-change, and per-input property naming, plus an IT that copies a ValueSignal, mutates it from a separate button, and verifies the next copy sees the updated value.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds SignalInput(Component owner, Signal signal) under com.vaadin.flow.component.trigger.internal. A component-scoped Signal.effect mirrors the signal value to a uniquely-named JS property on the owner element via executeJs; the input's rendered expression reads that property at fire time, so actions such as CopyTextToClipboardAction can use a server-side signal as their value source without first projecting it onto a DOM property.
Includes unit tests covering the rendered expression, push-on-change, and per-input property naming, plus an IT that copies a ValueSignal, mutates it from a separate button, and verifies the next copy sees the updated value.