Skip to content

feat: add popover opt-out configuration for loading indicator#24398

Open
platosha wants to merge 1 commit into
mainfrom
feat/connection-indicator-popover-opt-out
Open

feat: add popover opt-out configuration for loading indicator#24398
platosha wants to merge 1 commit into
mainfrom
feat/connection-indicator-popover-opt-out

Conversation

@platosha
Copy link
Copy Markdown
Contributor

Fixes #24072
Depends on vaadin/flow-hilla-common#26

  • Add Popover opt-out property with default value (false)
  • Implement listener for popover opt-out changes
  • Update ConfigurationMap to support the new setting
  • Add getter/setter methods in LoadingIndicatorConfiguration.java
  • Include test cases for popover opt-out functionality

Fixes #24072
Depends on vaadin/flow-hilla-common#26

- Add Popover opt-out property with default value (false)
- Implement listener for popover opt-out changes
- Update ConfigurationMap to support the new setting
- Add getter/setter methods in LoadingIndicatorConfiguration.java
- Include test cases for popover opt-out functionality
@github-actions
Copy link
Copy Markdown

Format Checker Report

BLOCKER There are 3 files with format errors

  • To see a complete report of formatting issues, download the differences artifact

  • To fix the build, please run mvn spotless:apply in your branch and commit the changes.

  • Optionally you might add the following line in your .git/hooks/pre-commit file:

    mvn spotless:apply
    

Here is the list of files with format issues in your PR:

flow-client/src/main/java/com/vaadin/client/communication/LoadingIndicatorConfigurator.java
flow-server/src/main/java/com/vaadin/flow/component/page/LoadingIndicatorConfiguration.java
flow-server/src/test/java/com/vaadin/flow/internal/nodefeature/LoadingIndicatorConfigurationMapTest.java

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

Test Results

 1 410 files  ±0   1 410 suites  ±0   1h 18m 26s ⏱️ - 1m 29s
10 161 tests +1  10 092 ✅ +1  69 💤 ±0  0 ❌ ±0 
10 636 runs  +1  10 565 ✅ +1  71 💤 ±0  0 ❌ ±0 

Results for commit 9ad63ee. ± Comparison against base commit 3697241.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vaadin-connection-indicator sets popover="manual" causing status message flicker and incorrect positioning

1 participant