fixed problem in range_to when hue should've cycled.#48
Open
alexhagen wants to merge 4 commits intovaab:masterfrom
Open
fixed problem in range_to when hue should've cycled.#48alexhagen wants to merge 4 commits intovaab:masterfrom
alexhagen wants to merge 4 commits intovaab:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
- Coverage 99.13% 96.81% -2.33%
==========================================
Files 1 1
Lines 232 251 +19
==========================================
+ Hits 230 243 +13
- Misses 2 8 +6
Continue to review full report at Codecov.
|
vokimon
suggested changes
Nov 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when performing
range_toon colors with hues that crossed1.0, thecolor_scalefunction used inrange_towould go through all intervening hues instead of crossing1.0. For example, when going from purple with hue0.94to red with hue0.04,range_toreturned almost all colors (blue, green, yellow) by ranging from0.94downward to0.04instead of going from0.94to1.0and then restarting at0.0and going to0.4. This commit fixes that.