refactor: standardize user imports#480
Merged
Merged
Conversation
…import elsewhere - All ForeignKey/OneToOneField definitions now use settings.AUTH_USER_MODEL - Removed get_user_model() calls from models and factories (were only used for field definitions or were unused) - core/factories.py: consolidated Group and User into single direct import - dashboard/factories.py, roster/factories.py: removed unused User = get_user_model() https://claude.ai/code/session_01BwTN4SGMjTfDAkQQLKgp8H
…t_user_model() Also includes minor ruff formatting fixes from make fmt. https://claude.ai/code/session_01BwTN4SGMjTfDAkQQLKgp8H
Coverage Report for CI Build 24318111866Coverage decreased (-0.005%) to 93.782%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Reverts to a single consistent pattern across the entire codebase: always import User directly from django.contrib.auth.models. https://claude.ai/code/session_01BwTN4SGMjTfDAkQQLKgp8H
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clean things up to be consistent
just use
auth.Userrather thanget_user_model()orsettings.AUTH_USER_MODEL