Software Challenge Urban Pistek#11
Open
UrbanPistek wants to merge 9 commits intouwrobotics:masterfrom
Open
Conversation
Made small chnages to main and resetTurtle
azumnanji
reviewed
Nov 5, 2020
azumnanji
reviewed
Nov 5, 2020
azumnanji
reviewed
Nov 5, 2020
azumnanji
reviewed
Nov 5, 2020
azumnanji
reviewed
Nov 5, 2020
azumnanji
reviewed
Nov 5, 2020
azumnanji
reviewed
Nov 5, 2020
azumnanji
reviewed
Nov 5, 2020
azumnanji
reviewed
Nov 5, 2020
azumnanji
reviewed
Nov 13, 2020
| } else { | ||
| ROS_INFO("Action Failed"); | ||
| //Infinite loop to run | ||
| while(true){ |
There was a problem hiding this comment.
if you look at the tutorials we want all loops to kill if the ros master is killed so we usually use while (ros::ok())
azumnanji
reviewed
Nov 13, 2020
| ROS_INFO("Action Finished"); | ||
| } else { | ||
| ROS_INFO("Action Failed"); | ||
| } |
There was a problem hiding this comment.
you're missing the ros::spinOnce function, this is the function that checks for new msgs, service calls, actions and other. its what lets us communicate between many applications running ros
azumnanji
reviewed
Nov 13, 2020
| int main(int argc, char **argv) { | ||
| ros::init(argc, argv, "moveTurtle"); | ||
| ros::NodeHandle nh; | ||
| MoveTurtleAction(std::string name) : |
There was a problem hiding this comment.
copy nodehandle to class nodehandle
Author
There was a problem hiding this comment.
Do you mean to put nodehandle in its own class?
Currently nodehandle is in the MoveTurtleActionClass:
class MoveTurtleAction { protected: ros::NodeHandle nh;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello here is my code for the software challenge, let me know what you think, thanks!