Repository navigation
adds userservice - #312
Merged
Merged
adds userservice#312
Conversation
Coverage Report for CI Build 27699618901Coverage decreased (-1.1%) to 97.072%Details
Uncovered Changes
Coverage Regressions2 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
This PR integrates django-userservice to centralize UWNetID resolution (including override/“act as” support) and updates views, settings, and tests to use it instead of uw_saml.utils.get_user.
Changes:
- Add
django-userservicedependency and wire it into the Docker Django settings (installed app, middleware, auth/validation hooks). - Switch page + user-preference API codepaths to derive UWNetID via
UserService. - Expand person DAO output for non-students and add UWNetID validation; update tests accordingly.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
setup.py |
Adds django-userservice dependency. |
pathways/views/pages.py |
Uses UserService for UWNetID in page context/person lookup. |
pathways/views/api/user.py |
Uses UserService to associate preferences with the current UWNetID. |
pathways/views/__init__.py |
Adds override authorization hook for userservice. |
pathways/log.py |
Introduces request-scoped user/actas logging via middleware + log filter. |
pathways/dao/person.py |
Returns base identity fields for non-students; adds valid_uwnetid. |
docker/settings.py |
Enables userservice app/middleware and configures validation/override hooks. |
docker/urls.py |
Routes /support/ to userservice URLs and moves persistent message URLs. |
pathways/tests/test_views.py |
Updates view tests to use userservice middleware and patched netid. |
pathways/tests/test_person.py |
Updates DAO expectations and adds validation tests. |
pathways/tests/test_api.py |
Updates API test setup for userservice session/middleware. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
devights
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.