Skip to content

fetch-gnu.sh: Use thirdparty-artifacts & verify checksum - #155

Merged
lhecker merged 1 commit into
uutils:mainfrom
oech3:patch-1
Nov 2, 2026
Merged

lhecker merged 1 commit into
uutils:mainfrom
oech3:patch-1

Conversation

@oech3

@oech3 oech3 commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@codspeed

codspeed Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ 3 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 10 untouched benchmarks
⏩ 17 skipped benchmarks1


Comparing oech3:patch-1 (9043d5c) with main (3396a03)

Open in CodSpeed

Footnotes

  1. 17 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Comment thread util/fetch-gnu.sh Outdated
# util/run-gnu-testsuite.sh drives against the Rust grep binary.
ver="3.12"
curl -L "https://ftp.gnu.org/gnu/grep/grep-${ver}.tar.xz" | tar --strip-components=1 -xJf -
blake2b="93d06bce04793f4b4c94d92febc6092f669e50e1bfc1bef3c911a2ca322560bdab8619e88a05a4d6ea4908b2d01da1926a99a22eecc513bd48b8957984bdfa12"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally speaking, I'd prefer SHA256. Is blake2b widely used in uutils?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I choiced b2 because it is fast.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my CPUs sha256sum actually appears to be almost 2x faster!

Comment thread util/fetch-gnu.sh Resolved

@lhecker lhecker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lhecker
lhecker merged commit a392706 into uutils:main Nov 2, 2026
22 checks passed
@oech3
oech3 deleted the patch-1 branch November 2, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants