cat: Improve performance on Linux#1978
Merged
sylvestre merged 6 commits intouutils:masterfrom Apr 1, 2021
Merged
Conversation
On my MacBook Pro 2020, it is around 25% faster to not use io::copy.
Arcterus
reviewed
Mar 31, 2021
Collaborator
Arcterus
left a comment
There was a problem hiding this comment.
Looks pretty good. In the future, I think we'll want to extract the splice() bits into a function or a type that serves as both a reader and a writer and throw it into uucore, but that can be done later.
This was referenced Apr 3, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should improve
catperformance, especially on Linux. It does this by:Box<dyn Trait>).spliceon LinuxThis PR supercedes #1289
Unscientific benchmarks
GNU
catBefore removing trait box, without Linux specialization
After removing trait box, without Linux specialization
This is the figure you should expect for non Linux platforms.
Linux specialization