Conversation
fireairforce
force-pushed
the
bump-next-js
branch
from
4d4eba4 to
930faa2
Compare
fireairforce
changed the title
fireairforce
changed the title
fireairforce
force-pushed
the
bump-next-js
branch
from
930faa2 to
577e829
Compare
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on a significant version bump for Turbopack and SWC dependencies, bringing them up to version 57. This update necessitated extensive changes across various Rust crates, including core components, NAPI bindings, and testing infrastructure. Additionally, the PR introduces refactored NAPI integration for improved error handling and project lifecycle management, alongside a substantial overhaul of the HMR runtime logic to enhance its shared implementation and module update mechanisms. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
fireairforce
force-pushed
the
bump-next-js
branch
from
577e829 to
55196f3
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request primarily involves updating Turbopack and SWC dependencies, leading to significant refactoring, an improved project initialization and update flow, the introduction of a TurbopackContext for better state management within the NAPI layer, and a new plugin execution strategy. A security audit identified a potential path traversal vulnerability where the TURBOPACK_TASK_STATISTICS environment variable is used to specify an arbitrary file path for writing task statistics without proper validation, which could allow an attacker to overwrite sensitive files. Additionally, the review identified a potential compilation error due to a typo and a significant logical change in how entrypoints are handled, which might be an unintended regression.
fireairforce
force-pushed
the
bump-next-js
branch
3 times, most recently
from
f98c4fc to
9c00f89
Compare
Previously, path.write() effects emitted inside snapshot_issues() were collected as collectibles of inner_operation itself, but only get_effects(out_op) (the bundler operation) was applied. This meant UPDATE=1 tests would pass without ever writing the issues files to disk. Fix: wrap snapshot_issues in its own turbo_tasks operation (snapshot_issues_operation). Its path.write() effects become collectibles of that sub-operation. Inside inner_operation (a turbo-tasks function, not a top-level task) we can legally call get_effects(snap_op).apply() to flush those writes before returning the bundler effects. Also adds the style/less issues snapshot file generated by this fix.
fireairforce
force-pushed
the
bump-next-js
branch
from
9c00f89 to
95eff78
Compare
xusd320
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes: #2657
Test Plan