feat(pack-cli): support JS config (utoopack.config.mjs/js) and defineConfig#2666
feat(pack-cli): support JS config (utoopack.config.mjs/js) and defineConfig#2666
Conversation
…Config - pack-cli: resolveFromConfigFile with json/mjs/js, async resolveBuildOptions - pack: defineConfig() and UserConfig type in pack-shared - examples/config-js: add example project for JS config Co-authored-by: Cursor <cursoragent@cursor.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the flexibility of the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for JavaScript configuration files (utoopack.config.mjs/js) and a defineConfig helper, which is a valuable enhancement for providing more dynamic and type-safe configurations. The implementation is well-structured, including a new example project and necessary updates to the CLI logic. My review includes one suggestion to improve the file reading logic to be fully asynchronous, aligning with best practices for Node.js applications.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Made-with: Cursor
Summary
Support JS config files and
defineConfighelper.Changes
resolveFromConfigFilefor json/mjs/js, asyncresolveBuildOptionsdefineConfig()andUserConfigtype in pack-sharedNote
TypeScript config (
utoopack.config.ts) is supported only on Node.js v24+ (native TS execution). Seepackages/pack-cli/src/utils/common.tsforCONFIG_FILE_NAMESand TS extension.Made with Cursor