-
Notifications
You must be signed in to change notification settings - Fork 112
fix: circular barrel file #2626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "config": { | ||
| "entry": [ | ||
| { | ||
| "import": "input/index.js", | ||
| "name": "main" | ||
| } | ||
| ], | ||
| "optimization": { | ||
| "minify": false, | ||
| "moduleIds": "named" | ||
| } | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import { Path } from './shape/index.js'; | ||
|
|
||
| export default Path; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import { makeArrow } from '../util/arrow.js'; | ||
|
|
||
| export default class Base { | ||
| constructor() { | ||
| this.type = 'base'; | ||
| } | ||
| getArrow() { | ||
| return makeArrow(this); | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| export { default as Base } from './base.js'; | ||
| export { default as Path } from './path.js'; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import Base from './base.js'; | ||
|
|
||
| export default class Path extends Base { | ||
| constructor() { | ||
| super(); | ||
| this.type = 'path'; | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import { Path } from '../shape/index.js'; | ||
|
|
||
| export function makeArrow(shape) { | ||
| return new Path(); | ||
| } | ||
|
Comment on lines
+3
to
+5
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| (globalThis["TURBOPACK"] || (globalThis["TURBOPACK"] = [])).push([ | ||
| typeof document === "object" ? document.currentScript : undefined, | ||
| {"otherChunks":["input_3c0c4cdb.js"],"runtimeModuleIds":["[project]/reexport_cycle_class_extends/input/index.js [client] (ecmascript)"]} | ||
| ]); | ||
| // Dummy runtime |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To align with the suggested change in
input/util/arrow.js, the argument passed tomakeArrowshould be removed since the corresponding parameter is unused.