Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"config": {
"entry": [
{
"import": "input/index.js",
"name": "main"
}
],
"optimization": {
"minify": false,
"moduleIds": "named"
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { Path } from './shape/index.js';

export default Path;
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import { makeArrow } from '../util/arrow.js';

export default class Base {
constructor() {
this.type = 'base';
}
getArrow() {
return makeArrow(this);
}
Comment on lines +7 to +9
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To align with the suggested change in input/util/arrow.js, the argument passed to makeArrow should be removed since the corresponding parameter is unused.

Suggested change
getArrow() {
return makeArrow(this);
}
getArrow() {
return makeArrow();
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export { default as Base } from './base.js';
export { default as Path } from './path.js';
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import Base from './base.js';

export default class Path extends Base {
constructor() {
super();
this.type = 'path';
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { Path } from '../shape/index.js';

export function makeArrow(shape) {
return new Path();
}
Comment on lines +3 to +5
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The shape parameter in the makeArrow function is unused. To improve code clarity and avoid confusion, it should be removed.

Suggested change
export function makeArrow(shape) {
return new Path();
}
export function makeArrow() {
return new Path();
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
(globalThis["TURBOPACK"] || (globalThis["TURBOPACK"] = [])).push([
typeof document === "object" ? document.currentScript : undefined,
{"otherChunks":["input_3c0c4cdb.js"],"runtimeModuleIds":["[project]/reexport_cycle_class_extends/input/index.js [client] (ecmascript)"]}
]);
// Dummy runtime

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading