feat(pack): support runtime entry bootstrap#2449
Conversation
Summary of ChangesHello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求引入了一个新的配置选项 Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| #[derive( | ||
| Clone, Debug, PartialEq, Eq, Serialize, Deserialize, TraceRawVcs, NonLocalValue, OperationValue, | ||
| )] | ||
| #[serde(untagged)] | ||
| pub enum RuntimeBootstrapConfig { | ||
| /// Inline JavaScript code | ||
| Code(RcStr), | ||
| /// Path to a JavaScript/TypeScript file | ||
| Path(RcStr), | ||
| } |
There was a problem hiding this comment.
RuntimeBootstrapConfig 枚举的定义存在一个严重问题。当 #[serde(untagged)] 与两个都包装了 RcStr（类似于 String）的变体一起使用时，serde 无法区分它们。在反序列化时，任何字符串值（无论是内联代码还是文件路径）都将被错误地解析为第一个变体，即 Code(RcStr)。这会导致文件路径被当作内联代码处理，从而引发运行时错误。
为了解决这个问题，建议将其中一个变体（例如 Path）修改为结构体，以便 serde 能够根据 JSON 结构进行区分。例如，用户可以通过 { "path": "./bootstrap.js" } 来指定文件路径，通过 "console.log('hello')" 来指定内联代码。
同时，别忘了更新 crates/pack-core/src/client/context.rs 中对应的 match 分支来匹配新的结构 (e.g. RuntimeBootstrapConfig::Path { path } => ...)。
pub enum RuntimeBootstrapConfig {
/// Path to a JavaScript/TypeScript file, as an object: `{ "path": "./bootstrap.js" }`
Path { path: RcStr },
/// Inline JavaScript code, as a string
Code(RcStr),
}| if let Some(bootstrap_config) = bootstrap_config_opt.as_ref() { | ||
| match bootstrap_config { | ||
| crate::config::RuntimeBootstrapConfig::Code(code) => { | ||
| // Inline code: create a virtual source | ||
| let bootstrap_source = VirtualSource::new( | ||
| project_root.join("__runtime_bootstrap__.js")?, | ||
| AssetContent::file(File::from(code.clone()).into()), | ||
| ) | ||
| .to_resolved() | ||
| .await?; | ||
| runtime_entries.push( | ||
| RuntimeEntry::Source(ResolvedVc::upcast(bootstrap_source)).resolved_cell(), | ||
| ); | ||
| } | ||
| crate::config::RuntimeBootstrapConfig::Path(path) => { | ||
| // File path: use FileSource to load the file | ||
| let bootstrap_path = project_root.join(path.as_str())?; | ||
| let bootstrap_source = FileSource::new(bootstrap_path).to_resolved().await?; | ||
| runtime_entries.push( | ||
| RuntimeEntry::Source(ResolvedVc::upcast(bootstrap_source)).resolved_cell(), | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
match 表达式的 Code 和 Path 分支中存在代码重复。创建 bootstrap_source 后的逻辑（即 runtime_entries.push(...)）是完全相同的。建议将这部分通用逻辑提取到 match 表达式之外，以减少重复并提高代码的可读性和可维护性。
let bootstrap_source = match bootstrap_config {
crate::config::RuntimeBootstrapConfig::Code(code) => {
// Inline code: create a virtual source
VirtualSource::new(
project_root.join("__runtime_bootstrap__.js")?,
AssetContent::file(File::from(code.clone()).into()),
)
.to_resolved()
.await?
}
crate::config::RuntimeBootstrapConfig::Path(path) => {
// File path: use FileSource to load the file
let bootstrap_path = project_root.join(path.as_str())?;
FileSource::new(bootstrap_path).to_resolved().await?
}
};
runtime_entries.push(
RuntimeEntry::Source(ResolvedVc::upcast(bootstrap_source)).resolved_cell(),
);
xusd320
force-pushed
the
next
branch
2 times, most recently
from
f77808c to
567e5ae
Compare
1 participant
Summary
加个通用的 runtimeEntryBoostrap 配置来往运行时之前插入一些可执行的代码。
目前是为了去适配qiankun的加载。
Test Plan