Revamp dev setup to match production environment#75
Open
embeddedt wants to merge 1 commit intoutmgdsc:dev/gdsc-open-source-2022from
Open
Revamp dev setup to match production environment#75embeddedt wants to merge 1 commit intoutmgdsc:dev/gdsc-open-source-2022from
embeddedt wants to merge 1 commit intoutmgdsc:dev/gdsc-open-source-2022from
Conversation
e1c226c to
9eed2b2
Compare
Member
|
I would add this as a separate setup on the readme rather than removing the local dev setup. Containerizing everything gets tedious and slows dev work when debugging/making changes. Even with remote debugging, making changes and recompiling them takes a while |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended to fix #68. A new
devproxycontainer is added that runs Apache and sits in front of the existing Nginx proxy. (This is technically redundant, but it matches the production environment, as far as I know.)I gave up on trying to get Shibboleth to work. It's very picky about the server name in order to work properly, and I didn't think it was worth investing more than the 2 hours I had spent. So, I just hardcoded a utorid into the Apache configuration so that it mimics the behavior of the real Shibboleth proxy. I think this is good enough for now, but happy to hear other opinions.
As a result of these changes, the entire dev environment is now run inside Docker Compose as well, using a special command to load the development yml file instead of the production one. Thus, no manual changes are required after cloning to have a fully working setup. 🎉
I'm opening this as a starting point for further discussion on how we want this to look, so it's a draft for now.