Skip to content

Fix bug where listRefresh() would not deduplicate already existing VMs in list #7816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avighnac wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

Fix bug where listRefresh() would not deduplicate already existing VMs in list #7816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Platform/UTMData.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,12 +144,18 @@ enum AlertItem: Identifiable {
///
/// This removes stale entries (deleted/not accessible) and duplicate entries
func listRefresh() async {
// deduplicate VM list
var list: [VMData] = [];
for vm in virtualMachines {
if !list.contains(where: { isSameFile($0.pathUrl, as: vm.pathUrl) }) {
list.append(vm)
}
}
// create Documents directory if it doesn't exist
if !fileManager.fileExists(atPath: Self.defaultStorageUrl.path) {
try? fileManager.createDirectory(at: Self.defaultStorageUrl, withIntermediateDirectories: false)
}
// wrap stale VMs
var list = virtualMachines
for i in list.indices.reversed() {
let vm = list[i]
if let registryEntry = vm.registryEntry, !fileManager.fileExists(atPath: registryEntry.package.path) {
Expand Down