fix: sync pyproject.toml dependencies with requirements.txt and add CodeQL SAST workflow#1703
fix: sync pyproject.toml dependencies with requirements.txt and add CodeQL SAST workflow#1703namann5 wants to merge 2 commits into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
utksh1
left a comment
There was a problem hiding this comment.
Thanks for the work here. This PR needs to be reshaped before merge:\n\n1. The dependency-sync part appears stale on current main, and parts of it would actually regress declarations (for example, changing httpx[cli] to plain httpx).\n2. The CodeQL workflow may be valuable, but it should be proposed in a clean, focused PR instead of being bundled with an obsolete dependency-sync change.\n3. Please rebase on current main and resubmit only the still-relevant part of this work.\n\nIf you want to keep the CodeQL addition, open a single-purpose PR for that alone.
cryptography, httpx, and openai are imported and used at runtime but were only declared in backend/requirements.txt. Anyone installing via pip install . would hit ImportError at runtime. Uses httpx[cli] (not plain httpx) to match setup.sh.
b2d1ec8 to
4bb3381
Compare
|
Reshaped per feedback — CodeQL and .python-version removed, rebased on current main. Now it's just the pyproject.toml fix adding the three missing runtime deps (cryptography, httpx[cli], openai). Used httpx[cli] to match setup.sh so nothing regresses. |
Summary
pyproject.toml declares runtime dependencies that are inconsistent with �ackend/requirements.txt. Three critical packages — cryptography, httpx, and openai — are present in
equirements.txt but missing from pyproject.toml.
This means any installation via pip install . or future PyPI publication silently omits these packages, causing runtime failures in core features:
Changes
Uses httpx[cli] (not plain httpx) to match the extras already installed by setup.sh.
Verification
Closes #1703