fix: allow api key cors preflight#1575
Open
Tomeshwari-02 wants to merge 1 commit into
Open
Conversation
utksh1
requested changes
Jul 3, 2026
utksh1
left a comment
Owner
There was a problem hiding this comment.
There is a merge conflict with the main branch. Please rebase your branch on the latest main to resolve the conflicts.
utksh1
requested changes
Jul 3, 2026
utksh1
left a comment
Owner
There was a problem hiding this comment.
Thanks for this contribution! I've reviewed the proposal and it looks like a valid addition. However, this branch currently has Git merge conflicts with main. Could you please pull the latest changes from upstream, resolve the conflicts, and push the rebased branch so we can continue the review process?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X-Api-Keyto the default CORS allowed headersSECUSCAN_CORS_ALLOWED_HEADERSdefault and override requirementWhy
The browser auth flow sends
X-Api-Keywhen establishing a session. Cross-origin browser frontends need the preflight response to allow that header.Fixes #1554
Validation
python -m pytest testing/backend/integration/test_cors.py -q