Fix #1489: Type-Unsafe Request Payloads (Missing Pydantic Models)#1517
Open
sahare-mayur-0071 wants to merge 4 commits into
Open
Fix #1489: Type-Unsafe Request Payloads (Missing Pydantic Models)#1517sahare-mayur-0071 wants to merge 4 commits into
sahare-mayur-0071 wants to merge 4 commits into
Conversation
utksh1
requested changes
Jul 1, 2026
utksh1
left a comment
Owner
There was a problem hiding this comment.
Holding off on merging this one. A couple of issues to address first:
- Encoding/mojibake corruption — the diff introduces broken characters in two existing comments (
ΓÇöwhere an em-dash—used to be) inroutes.py. This injects garbage bytes and must be reverted to the original UTF-8. - Overlap with other PRs — the type-safety refactor here spans the same target-policy / workflow / credential / session endpoints covered by the more focused #1514, #1515, and #1516 (now merged). Please rebase onto current
mainand resolve the inevitable conflicts, and consider narrowing scope to whatever isn't already covered.
Once the mojibake is fixed and it's rebased, happy to take another look.
…identally dropped
60d0860 to
1df3b54
Compare
Contributor
Author
|
Thanks for the feedback! I've fixed the mojibake encoding issue in |
utksh1
requested changes
Jul 3, 2026
utksh1
left a comment
Owner
There was a problem hiding this comment.
Thanks for this contribution! I've reviewed the proposal and it looks like a valid addition. However, this branch currently has Git merge conflicts with main. Could you please pull the latest changes from upstream, resolve the conflicts, and push the rebased branch so we can continue the review process?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1489