feat: DVD bounce mode easter egg with achievement unlock#1216
Closed
jeremybernstein wants to merge 1 commit intoutkarshdalal:masterfrom
Closed
feat: DVD bounce mode easter egg with achievement unlock#1216jeremybernstein wants to merge 1 commit intoutkarshdalal:masterfrom
jeremybernstein wants to merge 1 commit intoutkarshdalal:masterfrom
Conversation
Contributor
📝 WalkthroughWalkthroughAdds a DVD-bounce feature: two new persisted prefs (unlock + default), wired into the ambient download overlay to set/flip DVD mode and show an unlock notification, plus a conditional settings toggle and localized strings across multiple languages. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ShakeDetector
participant AmbientOverlay
participant PrefManager
participant AchievementNotificationManager
User->>ShakeDetector: shake
ShakeDetector->>AmbientOverlay: notify toggle
AmbientOverlay->>PrefManager: get dvdModeUnlocked
alt unlocked == false
AmbientOverlay->>PrefManager: set dvdModeUnlocked = true
AmbientOverlay->>AchievementNotificationManager: show(easter_egg_dvd_mode, iconUrl)
end
AmbientOverlay->>PrefManager: toggle/get dvdModeDefault as isDvdMode
AmbientOverlay-->>User: update UI (DVD bounce)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/src/main/res/values-es/strings.xml`:
- Line 1371: The Spanish locale is missing translations for
settings_dvd_mode_title and settings_dvd_mode_subtitle (only easter_egg_dvd_mode
exists), causing English fallback; open values-es/strings.xml and add localized
entries for settings_dvd_mode_title and settings_dvd_mode_subtitle (use the text
from values/strings.xml as the source and provide appropriate Spanish
translations), ensuring the keys exactly match the identifiers
settings_dvd_mode_title and settings_dvd_mode_subtitle so the toggle is fully
translated.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7e6d9099-5083-44b8-9ca0-753ca91942e3
📒 Files selected for processing (17)
app/src/main/java/app/gamenative/PrefManager.ktapp/src/main/java/app/gamenative/ui/screen/library/components/ambient/AmbientDownloadOverlay.ktapp/src/main/java/app/gamenative/ui/screen/settings/SettingsGroupInterface.ktapp/src/main/res/values-da/strings.xmlapp/src/main/res/values-de/strings.xmlapp/src/main/res/values-es/strings.xmlapp/src/main/res/values-fr/strings.xmlapp/src/main/res/values-it/strings.xmlapp/src/main/res/values-ko/strings.xmlapp/src/main/res/values-pl/strings.xmlapp/src/main/res/values-pt-rBR/strings.xmlapp/src/main/res/values-ro/strings.xmlapp/src/main/res/values-ru/strings.xmlapp/src/main/res/values-uk/strings.xmlapp/src/main/res/values-zh-rCN/strings.xmlapp/src/main/res/values-zh-rTW/strings.xmlapp/src/main/res/values/strings.xml
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 17 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/src/main/res/values-es/strings.xml">
<violation number="1" location="app/src/main/res/values-es/strings.xml:1371">
P3: Only `easter_egg_dvd_mode` is translated here; `settings_dvd_mode_title` and `settings_dvd_mode_subtitle` (added in `values/strings.xml`) are missing from this locale — and from every other non-English locale in this PR. The settings toggle will fall back to English for all non-English users. Add translations for both strings across all locales.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
shake during idle download triggers "Shaken, Not Stirred" achievement on first discovery, unlocks DVD bounce mode toggle in Interface settings. when enabled, idle downloads auto-enter bounce mode after timeout.
jeremybernstein
force-pushed
the
jb/dl-screen-easter-egg-pr
branch
from
4850cbf to
3ad47fe
Compare
Owner
|
Please don't add PRs without discussing in #code-changes. I'm closing this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a preference for using "DVD bounce mode" by default, but hiding it behind an easter egg for fun. On the download ambient screen, shaking the device during idle download triggers "DVD bounce mode" (added by @Producdevity). Now, that also triggers a "Shaken, Not Stirred" achievement notification (first-time only) and unlocks a hidden "DVD bounce mode" toggle in Interface settings.
dvdModeUnlockedprefRecording
dvd-bounce-easter-egg-web.mp4
Test plan
Checklist
Summary by cubic
Adds a hidden “DVD bounce mode” easter egg to the ambient download screen. Shaking the device while idle toggles bounce, shows a one-time “Shaken, Not Stirred” achievement, and unlocks a Settings toggle to make bounce mode the default.
dvdModeUnlockedanddvdModeDefault; toggle appears in Settings > Interface after unlock.dvdModeDefaultis on, idle downloads auto-enter bounce mode after the existing timeout.Written for commit 3ad47fe. Summary will update on new commits.
Summary by CodeRabbit
Release Notes