Skip to content

Added workaround for when globalThis is undefined. #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonmika merged 5 commits into from
Feb 25, 2026
Merged

Added workaround for when globalThis is undefined. #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f7180f
Added workaround if globalThis is not defined.
simonmika Feb 25, 2026
8d68950
Updated dependencies.
simonmika Feb 25, 2026
4cc4e22
Added omitting of auditing development dependencies.
simonmika Feb 25, 2026
f6e080e
Removed unused snapshots.
simonmika Feb 25, 2026
0808c6c
Improved coverage and reduced requirement.
simonmika Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: CI

on:
pull_request:

jobs:
build:
name: Build
Expand All @@ -12,7 +12,7 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version: 20.10.0
cache: 'npm'
cache: "npm"
- run: npm install
- run: npm run build
test:
Expand All @@ -23,7 +23,7 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version: 20.10.0
cache: 'npm'
cache: "npm"
- run: npm install
- run: npm run test
lint:
Expand All @@ -34,7 +34,7 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version: 20.10.0
cache: 'npm'
cache: "npm"
- run: npm install
- run: npm run lint
audit:
Expand All @@ -45,5 +45,5 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version: current
cache: 'npm'
- run: npm audit
cache: "npm"
- run: npm audit --omit dev
15 changes: 13 additions & 2 deletions Address/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,14 @@ describe("Address", () => {
zipCode: "",
city: "",
}
const genericWithRegion: isoly.Address.Generic = {
countryCode: "US",
street: "525 Market St",
zipCode: "94105",
city: "San Francisco",
state: "CA",
county: "San Francisco",
}
it.each([
[defaultAddress, true],
[britishAddress, true],
Expand All @@ -37,8 +45,11 @@ describe("Address", () => {
[badAddress, false],
])("British %s", (address, expected) => expect(isoly.Address.GB.is(address)).toBe(expected))
it.each([
[defaultAddress, false],
[britishAddress, false],
[swedishAddress, true],
[badAddress, false],
])("Swedish %s", (address, expected) => expect(isoly.Address.SE.is(address)).toBe(expected))
it.each([
[genericWithRegion, true],
[britishAddress, true],
])("Generic with region %s", (address, expected) => expect(isoly.Address.Generic.is(address)).toBe(expected))
})
Loading