fix(events): reject cross-tenant contact and email IDs on event tracking - #450
Merged
Conversation
POST /events/track passed the client-supplied contactId straight through to EventService.trackEvent, which started workflow executions for that contact without checking it belonged to the authenticated project. On multi-tenant installs this let one project run its workflows (emails, webhooks, contact field updates) against another project's contacts. The event row was also stored with the foreign contactId, so GET /events returned the other project's contact email in its contact join. Validate both IDs against the authenticated project in the controller, and verify contact.projectId === workflow.projectId in startWorkflowForContact as defense in depth for every other caller of trackEvent. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /events/track passed the client-supplied contactId straight through to EventService.trackEvent, which started workflow executions for that contact without checking it belonged to the authenticated project. On multi-tenant installs this let one project run its workflows (emails, webhooks, contact field updates) against another project's contacts. The event row was also stored with the foreign contactId, so GET /events returned the other project's contact email in its contact join.
Validate both IDs against the authenticated project in the controller, and verify contact.projectId === workflow.projectId in startWorkflowForContact as defense in depth for every other caller of trackEvent.