Repository navigation
fix: keep setup's background servers and end the port mirror with pier - #42
Merged
Merged
Conversation
When a setup script ends, its tmux window closes and the terminal hangs up on the window's session. A server the script started in the background last went with it — even wrapped in setsid, which races the script's exit. Setup now runs in its own session with no terminal (setsid -w, stdin from /dev/null), so nothing it starts is hung up on; the exit status still reaches the outcome file. The app also sorts sessions by name: the cloud returns instances in no fixed order, and rows that swapped between refreshes moved the cursor.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two lifetime fixes, and the README demo recorded against the current app.
.pier/setup.shstarted with&could be killed when the window closed, because the terminal hangup raced the script's exit. Setup now runs in its own session with stdin detached, so background jobs it starts keep running.-O exit.pier proxy, resize and delete.