Surface dropped buildx session diagnostics and raise session healthcheck tolerance#117
Open
Trent-TSE wants to merge 1 commit into
Open
Surface dropped buildx session diagnostics and raise session healthcheck tolerance#117Trent-TSE wants to merge 1 commit into
Trent-TSE wants to merge 1 commit into
Conversation
…eck tolerance Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a build maxes out runner memory (observed on sidestream-tech's cold-cache arm64 builds: ~0.04GB mem available, 93% iowait), the buildx client stalls past buildkitd's session healthcheck tolerance and the session carrying registry credentials is torn down mid-build. The eventual failure surfaces minutes later as a confusing push/auth error:
no active session for <id>: context deadline exceeded(/src/session/auth/auth.go:104).Two changes:
startBuildkitdnow setsBUILDKIT_SESSION_HEALTHCHECK_MAX_FAILURES=10by default (userdriver-optsenv.*values override it). This pairs with session: make healthcheck tolerance configurable via env vars buildkit#33, which makes the session healthcheck tolerance configurable via env vars — the var is inert until that lands in a fleet buildkit release.warnOnDroppedBuildkitSessions(): greps/tmp/buildkitd.logforhealthcheck failed fatally/no active sessionand emits acore.warningexplaining that memory pressure (not bad credentials) dropped the session, with the matching log lines.Updated the two
driver-optstests that asserted nosudo envprefix when no opts are passed, since a default env var is now always present.Verified with
pnpm typecheck,pnpm lint,pnpm test(29 passed), and the lefthook pre-commit build (dist/regenerated and committed).Link to Devin session: https://app.devin.ai/sessions/47b6abfcecd948dcbae7d55badefa46c
Requested by: @Trent-TSE
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled. (Staging)