fix: parse doc.creation to datetime in calculate_and_set_times#116
Open
expert369 wants to merge 2 commits into
Open
fix: parse doc.creation to datetime in calculate_and_set_times#116expert369 wants to merge 2 commits into
expert369 wants to merge 2 commits into
Conversation
Prevent TypeError when doc.creation is a string from API/form layer by converting it to datetime before time calculations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes (https://github.com/ury-erp/ury/issues/102)
🐛 Problem
doc.creation was being passed as a string from the form/API layer, which caused a TypeError when used in time calculations inside calculate_and_set_times.
🔧 Solution
This update ensures doc.creation is parsed into a proper datetime object using datetime.strptime() before any arithmetic operations are performed.
✔️ Result
Time calculations now execute correctly without errors, preventing failures during POS Invoice submission.