Гафурова Софья#86
Open
sofelvpopel wants to merge 5 commits into
Open
Conversation
|
🍅 Пройдено тестов 21 из 26 |
|
🍅 Пройдено тестов 21 из 23 |
|
🍅 Не пройден линтинг или базовые тесты |
|
🍏 Пройдено тестов 23 из 23 |
Xrias
requested changes
Oct 25, 2018
| * Реализован метод importFromCsv | ||
| */ | ||
| const isStar = true; | ||
| const isStar = false; |
There was a problem hiding this comment.
У тебя код написан на звездочку, а здесь false?
| */ | ||
| function add(phone, name, email) { | ||
| function add(phone, name = '', email = '') { | ||
| const validPhone = /^(\d)\1\1(\d)\2\2(\d)\3(\d)\4$/.test(phone); |
There was a problem hiding this comment.
Можно же /^\d{10}$/.test(phone). Повтори регулярки.
| const validPhone = /^(\d)\1\1(\d)\2\2(\d)\3(\d)\4$/.test(phone); | ||
| const contact = phoneBook[phone]; | ||
|
|
||
| if (!validPhone || !name || contact) { |
There was a problem hiding this comment.
!validPhone || !name || phoneBook[phone]
Можно и не выносить в переменную
| const result = findAll(query); | ||
|
|
||
| return result.map(c => { | ||
| let r = `${c.name}, ${toFullPhone(c.phone)}`; |
There was a problem hiding this comment.
Переименуй r и c на что-то информативное.
| return allContacts; | ||
| } | ||
|
|
||
| function toFullPhone(phone) { |
|
🍅 Пройдено тестов 23 из 26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.