Трубецких Евгений#61
Open
alidus wants to merge 5 commits into
Open
Conversation
|
🍅 Не пройден линтинг или базовые тесты |
|
🍅 Не пройден линтинг или базовые тесты |
|
🍅 Не пройден линтинг или базовые тесты |
|
🍏 Пройден линтинг и базовые тесты |
evilj0e
requested changes
Oct 24, 2017
Member
evilj0e
left a comment
evilj0e
left a comment
There was a problem hiding this comment.
Поправь бордер и форматирование. Хорошая работа, молодец
| "extends": "stylelint-config-hrundel" | ||
| } | ||
| "extends": "stylelint-config-hrundel", | ||
| "rules": { |
| font-family: 'Eczar', serif; | ||
| width: 100%; | ||
| height: 25px; | ||
| border: 5px solid; |
Member
There was a problem hiding this comment.
Можешь написать правила для бордера короче?
|
|
||
| body main { | ||
| overflow: auto; | ||
| overflow-y: hidden; |
|
|
||
| body main .article-container .articles-group-title { | ||
| text-align: center; | ||
| border: 3px solid; |
| } | ||
|
|
||
| body .margin-right { | ||
| margin-right: 40px; |
| } | ||
|
|
||
| body .margin-top { | ||
| margin-top: 20px; |
| <div class="header-text-separator"> | ||
| Lysva, Tuesday, October 25, 2016 | ||
| </div> | ||
|
|
| <div class="main-article-title"> | ||
| Catalan MPs to discuss response to Spanish move towards direct rule | ||
| </div> | ||
| <img class="main-article-img" src="https://goo.gl/Z2hzDN" alt=""> |
| Catalan MPs to discuss response to Spanish move towards direct rule | ||
| </div> | ||
| <img class="main-article-img" src="https://goo.gl/Z2hzDN" alt=""> | ||
| <p lang="en"> |
|
🍏 Пройден линтинг и базовые тесты |
evilj0e
reviewed
Nov 10, 2017
| border-left: none; | ||
| border-right: none; | ||
| padding: 5px; | ||
| font-family: 'Satisfy', cursive; |
Member
There was a problem hiding this comment.
В будущем добавляй больше шрифтов для деградации
evilj0e
reviewed
Nov 10, 2017
| float: right; | ||
| box-sizing: border-box; | ||
| width: 300px; | ||
| height: 100px; |
Member
There was a problem hiding this comment.
При выборе шрифтов тексты выезжает за границы блока. Поставь минимальную высоту, вместе фиксированной в 100px
evilj0e
reviewed
Nov 10, 2017
| goes awry. | ||
| </span> | ||
| <span class="advert">Buy our new bicycles for only 100$! | ||
| <br>Call us now: 8-800-555-35-35</span> |
Member
There was a problem hiding this comment.
Для телефонов есть своя разметка
evilj0e
reviewed
Nov 10, 2017
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>Задача «DeLorean DMC-12»</title> | ||
| <link rel="stylesheet" href="index.css" type="text/css"> |
Member
There was a problem hiding this comment.
Свои стили лучше подключать после шрифтов
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some rules for linter
Посмотреть решение