Хмелев Дмитрий#10
Open
NeSmogPridymatNick wants to merge 2 commits into
Open
Conversation
NeSmogPridymatNick
force-pushed
the
master
branch
from
8ae46c3 to
8f96dc3
Compare
zmenka
requested changes
May 19, 2017
Collaborator
zmenka
left a comment
zmenka
left a comment
There was a problem hiding this comment.
Все отлично, добавить только побольше кейсов
| // values you need to put in here in order to connect to these services. | ||
| // | ||
| user: 'Acedia123', | ||
| key: 'd41bb58c-1476-449a-897c-1d1578155ad2', |
Collaborator
There was a problem hiding this comment.
Лучше свои токены положить в переменные окружения
| .click('input[placeholder="Search"]') | ||
| .keys('usb') | ||
| .click('button[type="submit"]') | ||
| chai.assert.equal('USB Stick (Green),USB Stick (Leaf),USB Stick',browser.getText('div.col-md-5 > h3')); |
Collaborator
There was a problem hiding this comment.
Еще бы количество товаров проверить тогда. Или не отталкиваться от конкретных товаров, а проверить, что у всех найденных строка поиска в названии есть
| .click('button[type="submit"]') | ||
| chai.assert.equal('USB Stick (Green),USB Stick (Leaf),USB Stick',browser.getText('div.col-md-5 > h3')); | ||
| }); | ||
| it('Хлебные крошки', () => { |
Collaborator
There was a problem hiding this comment.
Еще есть хлебные крошки при поиске товаров, в корзине, при просмотре конкретного товара и на главное
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.