Петрова Ксения#12
Open
ksenipetrova wants to merge 1 commit into
Open
Conversation
zmenka
requested changes
May 17, 2017
Collaborator
zmenka
left a comment
zmenka
left a comment
There was a problem hiding this comment.
Не хватает тестов для получения твитов и в formatDate не хватает проверки на плохие аргументы, а так все хорошо
|
|
||
| function formatDate(date) { | ||
| // Напишите код форматирования даты в этом месте | ||
| date = new Date(date); |
Collaborator
There was a problem hiding this comment.
лучше входные данные не менять
|
|
||
| function formatDate(date) { | ||
| // Напишите код форматирования даты в этом месте | ||
| date = new Date(date); |
Collaborator
There was a problem hiding this comment.
а если из api некорректное что-то придет? null, например
zmenka
reviewed
May 17, 2017
| } | ||
|
|
||
| function getTweets () { | ||
| return new Promise((resolve, reject) => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.