Skip to content

[ci]: fix installation of {fs}, update pre-commit hooks#268

Merged
jameslamb merged 1 commit into
mainfrom
fix/ci
May 2, 2026
Merged

[ci]: fix installation of {fs}, update pre-commit hooks#268
jameslamb merged 1 commit into
mainfrom
fix/ci

Conversation

@jameslamb

Copy link
Copy Markdown
Collaborator

Linux CI is failing like this:

** package ‘fs’ successfully unpacked and MD5 sums checked
** using staged installation
Package libuv was not found in the pkg-config search path.
Perhaps you should add the directory containing `libuv.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libuv', required by 'virtual:world', not found
Using PKG_CFLAGS=
Using PKG_LIBS=-luv
--------------------------- [CONFIGURE] --------------------------------
Configuration failed because libuv was not found. Try installing:
 * deb: libuv1-dev (Debian, Ubuntu, etc)
 * rpm: libuv-devel (Fedora, EPEL)
 * brew: libuv (OSX)
Alternatively set environment variable USE_BUNDLED_LIBUV=1 to build a static
version of libuv that is included with this package.

(build link)

Recent changes in {fs} mean everyone that ends up building it from source now needs to either system install libuv or install CMake and set an environment variable... see lightgbm-org/LightGBM#7208 for more details.

This PR proposes using the system install of libuv (should be faster and less error-prone than building it from source in the {fs} build).

Also updates hooks w/ pre-commit autoupdate, just routine minor maintenance I wanted to tack on here to take advantage of the review and CI runs.

@jameslamb jameslamb added the maintenance miscellaneous maintenance label May 2, 2026
@jameslamb jameslamb changed the title WIP: [ci]: fix installation of {fs}, update pre-commit hooks [ci]: fix installation of {fs}, update pre-commit hooks May 2, 2026
@jameslamb jameslamb marked this pull request as ready for review May 2, 2026 02:36
@jameslamb jameslamb requested a review from austin3dickey as a code owner May 2, 2026 02:36

@austin3dickey austin3dickey left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jameslamb jameslamb merged commit d21f8cc into main May 2, 2026
13 of 15 checks passed
@jameslamb jameslamb deleted the fix/ci branch May 2, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance miscellaneous maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants