Skip to content

fix: prevent long keys from breaking modal and header layouts #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CahidArda merged 2 commits into from
May 15, 2026
Merged

fix: prevent long keys from breaking modal and header layouts #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c172b2
fix: prevent long unbreakable keys from breaking modal and header lay…
ytkimirti May 8, 2026
816a4c2
ci: pin pnpm to v9 for E2E workflow
ytkimirti May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/playwright.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
with:
node-version: lts/*
- name: Install dependencies
run: npm install -g pnpm && pnpm install
run: npm install -g pnpm@9 && pnpm install
- name: Install Playwright Browsers
run: pnpm exec playwright install --with-deps
- name: Run Playwright tests
Expand Down
2 changes: 1 addition & 1 deletion src/components/databrowser/components/delete-key-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export function DeleteKeyModal({
<DialogTitle>
{isPlural ? `Delete ${count} ${itemsLabel}` : `Delete ${itemLabel}`}
</DialogTitle>
<DialogDescription className="mt-5">
<DialogDescription className="mt-5 break-all">
Are you sure you want to delete{" "}
{name ? (
<>
Expand Down
2 changes: 1 addition & 1 deletion src/components/databrowser/components/display/display-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const DisplayHeader = ({
<div className="rounded-lg">
{/* Key title and actions */}
<div className="flex h-[26px] items-center justify-between gap-4">
<h2 className="grow truncate text-sm">
<h2 className="min-w-0 grow truncate text-sm">
{dataKey.trim() === "" ? (
<span className="ml-1 text-zinc-500">(Empty Key)</span>
) : (
Expand Down
8 changes: 4 additions & 4 deletions src/components/databrowser/components/header/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@ const IndexSelector = () => {
modal={false}
>
<PopoverTrigger asChild>
<button className="flex min-w-[140px] items-center justify-between gap-2 rounded-r-lg border border-zinc-300 bg-emerald-50 px-3 py-[5px] text-sm font-medium text-emerald-800 transition-colors hover:bg-emerald-100">
<span className="truncate">{index || "Select an index"}</span>
<button className="flex min-w-[140px] max-w-[240px] items-center justify-between gap-2 rounded-r-lg border border-zinc-300 bg-emerald-50 px-3 py-[5px] text-sm font-medium text-emerald-800 transition-colors hover:bg-emerald-100">
<span className="min-w-0 truncate">{index || "Select an index"}</span>
<IconChevronDown className="size-4 shrink-0 opacity-50" />
</button>
</PopoverTrigger>
Expand Down Expand Up @@ -172,11 +172,11 @@ const IndexSelector = () => {
setValuesSearchIndex(idx)
setOpen(false)
}}
className="flex flex-1 items-center gap-2 text-left text-sm"
className="flex min-w-0 flex-1 items-center gap-2 text-left text-sm"
>
<span
className={cn(
"flex size-5 items-center justify-center",
"flex size-5 shrink-0 items-center justify-center",
idx === index ? "text-emerald-600" : "text-transparent"
)}
>
Expand Down
Loading