Conversation
requiresAuthentication compared the raw request path with "/mcp/oauth". Express matches routes case-insensitively and with an optional trailing slash, so "/mcp/oauth/" and "/MCP/OAUTH" reached the OAuth handler while the gate treated them like the anonymous /mcp route. Compare the canonical form instead, the same normalization mcpRouteFromUrl already uses for telemetry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requiresAuthenticationinpackages/mcp/src/index.tsdecides whether a request hits the protected OAuth endpoint with an exact string compare against/mcp/oauth. Express 5 routes case-insensitively and with an optional trailing slash, butreq.baseUrlandreq.pathkeep the request's spelling. So/mcp/oauth/,/MCP/OAUTHor/Mcp/OAuth/reach the samemcpRouter.all("/oauth")handler while the gate says "not the OAuth endpoint", and those requests are served like the anonymous/mcproute instead of getting the 401 challenge.The telemetry layer already treats both spellings as the OAuth route (
mcpRouteFromUrlstrips trailing slashes and lowercases, see the test "labels both protected Express route spellings as OAuth"), so the two layers disagreed. This PR applies the same normalization in the gate:No routing changes, no behaviour change for
/mcpor for the exact/mcp/oauthspelling.Tests
New integration test "protects every spelling Express routes to the OAuth endpoint" posts an
initializerequest without credentials to/mcp/oauth/,/MCP/OAUTHand/Mcp/OAuth/against the built server and expects 401 for each. It fails onmaster(/mcp/oauth/: expected 200 to be 401) and passes with the fix.Changeset:
@upstash/context7-mcppatch.