Conversation
Library titles, descriptions, and doc snippets are crowdsourced. Sanitize them at the API boundary so a malicious entry cannot inject ANSI/OSC escape sequences into the user's terminal via ctx7 docs or ctx7 library. Reported by Syed Anas Mohiuddin. Claude-Session: https://claude.ai/code/session_01XXTv4m4tzcTPQYfa9DvGsv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ctx7 docsandctx7 libraryprinted API-returned content (library titles, descriptions, doc snippets) straight to stdout. Because the index is crowdsourced, a malicious library entry could embed raw ANSI/OSC escape sequences (screen clear, cursor moves, OSC 52 clipboard writes) that execute in the user's terminal.This adds a single
stripControlCharshelper inapi.tsand applies it at the trust boundary on the crowdsourced responses:resolveLibrary,searchLibraries, and both the text and JSON branches ofgetLibraryContext. It removes C0 controls (except tab and newline), DEL, and C1. Our own picocolors styling is unaffected since it is applied after sanitization.Verification
--json: zero ESC bytes reach stdoutCredit
Reported by Syed Anas Mohiuddin, independent security researcher.
https://claude.ai/code/session_01XXTv4m4tzcTPQYfa9DvGsv